Skip to content

Conversation

@KevinLiddle
Copy link
Contributor

Same issue as #21144 but the fix for that issue did not take into account path names that are normalized for Rust conventions (camelCase param names turning into snake_case). This fixes that check to account for that difference.

Rust Committee: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley

I didn't see a sample YAML file for rust-axum in the bin/configs/ directory. Let me know if there's something else I should do for that item in the PR checklist.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Sep 3, 2025

thanks for the pr

cc @linxGnu

Copy link
Contributor

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinLiddle thank you for the PR.

Basically LGTM. Could you please run integration test with following command:

mvn clean && ./bin/generate-samples.sh bin/configs/manual/rust-axum-* && mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

@KevinLiddle
Copy link
Contributor Author

@linxGnu I ran that command and pushed the updated sample for rust-axum. Thanks for the quick review!

@KevinLiddle KevinLiddle requested a review from linxGnu September 3, 2025 14:15
@wing328 wing328 merged commit 86f1070 into OpenAPITools:master Sep 3, 2025
18 checks passed
@wing328 wing328 added this to the 7.16.0 milestone Sep 3, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
…le tags on a path with a camelCase param (OpenAPITools#21873)

* [BUG][rust-axum] Fix duplicate route operations when supplying multiple tags on a path with a camelCase param

* Update rust-axum sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants