Skip to content

Conversation

@MercMayhem
Copy link
Contributor

Fix for the duplicate prefix / suffix addition to model names as mentioned in issue #22146. The bug causing the additional prefix was also what was causing the model not being imported like in the example provided in the issue. Building the code and generating the code will now yield the correct model names being generated as well as them being imported correctly. Fixes #22146 @cbornet, @tomplus, @krjakbrjak, @fa0311, @multani.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.18.0 milestone Nov 3, 2025
@wing328 wing328 merged commit 0ae50f5 into OpenAPITools:master Nov 3, 2025
14 checks passed
@wing328
Copy link
Member

wing328 commented Nov 3, 2025

tested locally to confirm the fix

let's give it a try

thanks for the PR

@wing328 wing328 changed the title Fixes #22146. Fixed the code to call the correct method to prevent duplication of Prefix added to the model when using --model-name-prefix [python] Fixed the code to call the correct method to prevent duplication of Prefix added to the model when using --model-name-prefix Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [python-fastapi] model-name-prefix and suffix generate broken code

2 participants