Skip to content

[python] Fix pyproject (poetry 2.x) for httpx #22289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
+28 −18
Merged

[python] Fix pyproject (poetry 2.x) for httpx #22289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9393ef5
fix poetry 2 httpx dependencies
wing328 Nov 5, 2025
4649885
use poetry 2 for tests
wing328 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/configs/python-httpx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ library: httpx
additionalProperties:
packageName: petstore_api
mapNumberTo: float
poetry1: true
poetry1: false
Copy link

@Dmitry9951 Dmitry9951 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, kindly, confirm not poetry-based pyproject.toml will be generated here?

Copy link
Member Author

@wing328 wing328 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting this option to false (default) will generate pyproject.toml supporting poetry 2.x

are you looking for an option to generate pyproject.toml that's not "poetry-based" ?

Copy link
Member Author

@wing328 wing328 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, looks like a new requirement so it will not be handled in this PR

Copy link

@Dmitry9951 Dmitry9951 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got it. Let's see, what will happen =)

nameMappings:
_type: underscore_type
type_: type_with_underscore
Expand Down
7 changes: 5 additions & 2 deletions modules/openapi-generator/src/main/resources/python/pyproject.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,13 @@ requires-python = ">=3.9"
dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
"python-dateutil (>=2.8.2)",
{{#async}}
{{#httpx}}
"httpx (>=0.28.1)",
{{/httpx}}
{{#asyncio}}
"aiohttp (>=3.8.4)",
"aiohttp-retry (>=2.8.3)",
{{/async}}
{{/asyncio}}
{{#tornado}}
"tornado (>=4.2,<5)",
{{/tornado}}
Expand Down
37 changes: 22 additions & 15 deletions samples/openapi3/client/petstore/python-httpx/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,32 @@
[tool.poetry]
[project]
name = "petstore_api"
version = "1.0.0"
description = "OpenAPI Petstore"
authors = ["OpenAPI Generator Community <[email protected]>"]
license = "Apache-2.0"
authors = [
{name = "OpenAPI Generator Community",email = "[email protected]"},
]
license = { text = "Apache-2.0" }
readme = "README.md"
repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"
keywords = ["OpenAPI", "OpenAPI-Generator", "OpenAPI Petstore"]
include = ["petstore_api/py.typed"]
requires-python = ">=3.9"

dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
"python-dateutil (>=2.8.2)",
"httpx (>=0.28.1)",
"pem (>=19.3.0)",
"pycryptodome (>=3.9.0)",
"pydantic (>=2)",
"typing-extensions (>=4.7.1)",
]

[project.urls]
Repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"

[tool.poetry.dependencies]
python = "^3.9"
urllib3 = ">= 2.1.0, < 3.0.0"
python-dateutil = ">= 2.8.2"
httpx = ">= 0.28.1"
pem = ">= 19.3.0"
pycryptodome = ">= 3.9.0"
pydantic = ">= 2"
typing-extensions = ">= 4.7.1"
[tool.poetry]
requires-poetry = ">=2.0"

[tool.poetry.dev-dependencies]
[tool.poetry.group.dev.dependencies]
pytest = ">= 7.2.1"
pytest-cov = ">= 2.8.1"
tox = ">= 3.9.0"
Expand Down
Loading