Skip to content

Conversation

@achton
Copy link
Contributor

@achton achton commented Nov 6, 2025

Fix PHP generator bug where nullable-but-required model properties were always flagged as invalid when set to null. Update validation/docblocks so explicit null assignments are honored. Closes #21497.

@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@achton achton changed the title [php] [php] Fix PHP generator validation for nullable required properties Nov 6, 2025
@achton achton force-pushed the fix-issue-21497-php-null-nullable branch from ec75a1d to 5e2e7e5 Compare November 7, 2025 12:15
* Sets {{name}}
*
* @param {{{dataType}}}{{^required}}|null{{/required}} ${{name}}{{#description}} {{{.}}}{{/description}}{{^description}} {{{name}}}{{/description}}
* @param {{{dataType}}}{{#isNullable}}|null{{/isNullable}} ${{name}}{{#description}} {{{.}}}{{/description}}{{^description}} {{{name}}}{{/description}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also apply the same update here to handle both required and optional properties?

{{#vars}}
{{#required}}
if ($this->container['{{name}}'] === null) {
if ($this->container['{{name}}'] === null{{#isNullable}} && !$this->isNullableSetToNull('{{name}}'){{/isNullable}}) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also apply the same update here to handle both required and optional properties?

@wing328
Copy link
Member

wing328 commented Nov 8, 2025

I'll address those comments with a separate PR

UPDATE: merged #22307

@wing328 wing328 merged commit fb444bf into OpenAPITools:master Nov 8, 2025
27 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 8, 2025
@wing328
Copy link
Member

wing328 commented Nov 9, 2025

FYI. Merged another PR (#22310) to refactor the template a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [php] Property is both nullable and non-nullable

2 participants