[cpp-rest] Fixing Incorrect Header Name Used #22298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
approved these changes
Nov 7, 2025
Contributor
Author
|
@aminya looks like I still need a approval from someone with write access? |
Contributor
Author
|
@wing328 could you merge this? |
Contributor
|
It usually takes a few days before the maintainers get to all the PRs |
Member
|
FYI. Merged #22306 to add a test to the existing client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22297
@aminya
If I have a security scheme defined as
api_keywhich uses the header namex-api-key, suddenly neither work with the cpp-restsdk generator. It works with other generators - they fetch the correct header name from the security scheme name.I ran the generation of the test snapshot but there are no changes since in the test the security scheme and key name are the same.
If desired I can add a test for this specific scenario. I verified it by using the built generator on our SDK.