-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[JAVA jaxrs-spec gen] add option for generating swagger V3 annotations #22300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the pr let me know if this's ready for review |
| @@ -0,0 +1,11 @@ | |||
| generatorName: jaxrs-spec | |||
| outputDir: samples/server/petstore/jaxrs-spec-swagger-annotations | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the folder to the CI: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-jaxrs.yaml
so that it will be tested moved forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll do it in a separate pr. thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: done via #22314
Fixes #12379
Add option useSwaggerV3Annotations for generating Swagger V3 Annotations to jaxrs-spec generator.
Default is false for useSwaggerV3Annotations.
When useSwaggerV3Annotations is set to true, the Swagger V2 annotation option(useSwaggerAnnotations) is automatically set to false.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)