-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Java] Support Deprecation of Generated enum-classes
#22312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enum-classes with @Deprecatedenum-classes
| * {{description}}{{^description}}Gets or Sets {{{name}}}{{/description}} | ||
| */ | ||
| {{#gson}} | ||
| {{#isDeprecated}}@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
{{#isDeprecated}}
@Deprecated
{{/isDeprecated}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in an empty line, like:
/*
* javadoc here...
*/
@DeprecatedAlso, making a newline between {{/isDeprecated}} and {{#gson}} will always generate another empty line after the deprecated-annotation, or result to 2 empty lines after the javadocs.
Is this OK? (from a Style-Guide perspective)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wing328, the suggested change has been done, and the updated samples have been committed too. 👍
Signed-off-by: Chrimle <[email protected]>
|
Hello @wing328 ! Personally, with reference to the google-java-format, the new line added to these classes is not conforming to the format. Is this OK, or should I address this at the same time as your suggestion? Cheers |
Signed-off-by: Chrimle <[email protected]>
Signed-off-by: Chrimle <[email protected]>
|
Will update the other Java templates too. |
Signed-off-by: Chrimle <[email protected]>
Signed-off-by: Chrimle <[email protected]>
Signed-off-by: Chrimle <[email protected]>
Signed-off-by: Chrimle <[email protected]>
Signed-off-by: Chrimle <[email protected]>
|
No other files have been updated. Ready for review! |
|
Pinging the Java Tech Committee 🔔 Hopefully this is how it is intended 🙏 |
|
looks good to me. let's give it a try i'll add a test in another PR done via #22335 |
Adds support for generated
enum-classes to be annotated@Deprecatedwhendeprecated: trueis set in the OpenAPI-schema, similarly to how it is done when generating classes. Note: this annotation is not applied to innerenum-classes.Fixes #22311.
OpenAPI Schema:
Results in:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)