Skip to content

Clarify when no alerts are present during timeframe #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ItsmeCurly
Copy link

When no alerts are found, the resources is empty, so we exit before querying the alerts and clarify the error message.

Proposed changes

  • Clarify logging, exit function before requesting alerts if no alerts found

Related issues

  • N/A

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

When no alerts are found, the resources is empty, so we exit before
querying the alerts and clarify the error message.
@RomuDeuxfois
Copy link
Member

Hi,

Thank you so much for your contribution to the OpenBAS project.
To merge your work, all your commits need to be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants