[backend/frontend] Manage architecture for OpenBAS implant #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #2908 +/- ##
=====================================================
+ Coverage 40.00% 40.18% +0.17%
- Complexity 2123 2124 +1
=====================================================
Files 646 647 +1
Lines 20065 20082 +17
Branches 1369 1369
=====================================================
+ Hits 8027 8069 +42
+ Misses 11597 11563 -34
- Partials 441 450 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| private CrowdStrikeDevice crowdstrikeAgent; | ||
| private Executor crowdstrikeExecutor; | ||
|
|
||
| private void initCsAgent() { |
There was a problem hiding this comment.
nitpick: Could be put in a fixture class
| WINDOWS_ARCH | ||
| + WINDOWS_EXTERNAL_REFERENCE | ||
| + command.replace( | ||
| Endpoint.PLATFORM_ARCH.x86_64.name(), |
There was a problem hiding this comment.
I don't understand this part
Comment on lines
+400
to
+409
| InjectStatus injectStatus = | ||
| inject.getStatus().orElseThrow(() -> new IllegalArgumentException("Status should exist")); | ||
| injectStatus.addTrace(ExecutionTraceStatus.ERROR, message, ExecutionTraceAction.START, agent); | ||
| injectStatusRepository.save(injectStatus); | ||
| InjectExecutionInput input = new InjectExecutionInput(); | ||
| input.setMessage("Execution done"); | ||
| input.setStatus(ExecutionTraceStatus.INFO.name()); | ||
| input.setAction(InjectExecutionAction.complete); | ||
| injectStatusService.updateInjectStatus(agent, inject, input); | ||
| } |
There was a problem hiding this comment.
@MarineLeM can you confirm this trace part ? Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist