Skip to content

[backend] Added bulk create expectation traces endpoint #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025

Conversation

impolitepanda
Copy link
Member

@impolitepanda impolitepanda commented Apr 14, 2025

Proposed changes

  • Added bulk create expectation traces endpoint

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.30%. Comparing base (590a994) to head (cce271f).
Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...a/io/openbas/service/InjectExpectationService.java 84.84% 3 Missing and 2 partials ⚠️
...t_expectation_trace/InjectExpectationTraceApi.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2945      +/-   ##
=====================================================
+ Coverage              40.14%   40.30%   +0.15%     
- Complexity              2177     2190      +13     
=====================================================
  Files                    660      661       +1     
  Lines                  20440    20500      +60     
  Branches                1394     1396       +2     
=====================================================
+ Hits                    8206     8262      +56     
- Misses                 11785    11787       +2     
- Partials                 449      451       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@impolitepanda impolitepanda marked this pull request as ready for review April 15, 2025 02:18
@antoinemzs antoinemzs self-requested a review April 15, 2025 07:25
@impolitepanda impolitepanda changed the title Added bulk create expectation traces endpoint [backend] Added bulk create expectation traces endpoint Apr 18, 2025
@impolitepanda impolitepanda force-pushed the issue/2873 branch 6 times, most recently from 1bb0a5f to d01cc0c Compare April 22, 2025 07:07
Copy link
Contributor

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

good to know we have a schema constraint now :)

@impolitepanda impolitepanda merged commit f1557ed into release/current Apr 22, 2025
7 checks passed
@impolitepanda impolitepanda deleted the issue/2873 branch April 22, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants