Skip to content

[frontend] add ee highlight #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: issue/2838-chunk-2
Choose a base branch
from

Conversation

MarineLeM
Copy link
Contributor

Proposed changes

on install agents :

  • Add EE highlights
  • Add an informational message in the installation crowdstrike modal

on endpoint page

  • Add EE highlights on crowdstrike

Related issues

Further comments

image
image
image

@MarineLeM MarineLeM self-assigned this Apr 18, 2025
@MarineLeM MarineLeM added the filigran team use to identify PR from the Filigran team label Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.87%. Comparing base (01c6e7d) to head (da03f92).

Additional details and impacted files
@@                  Coverage Diff                  @@
##             issue/2838-chunk-2    #2998   +/-   ##
=====================================================
  Coverage                 39.87%   39.87%           
  Complexity                 2178     2178           
=====================================================
  Files                       659      659           
  Lines                     20435    20435           
  Branches                   1408     1408           
=====================================================
  Hits                       8149     8149           
  Misses                    11839    11839           
  Partials                    447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -84,6 +82,7 @@ const Executors = () => {
<ExecutorSelector
executor={executor}
setSelectedExecutor={setSelectedExecutor}
isEEExecutor={executor.executor_type == OPENBAS_TANIUM || executor.executor_type == OPENBAS_CROWDSTRIKE}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (for the whole PR): shouldn't we add this as a more generic property somewhere ? Maybe we need to add a isEE propetry in all executors in addition to the executor_type ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants