-
Notifications
You must be signed in to change notification settings - Fork 111
[frontend] add ee highlight #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue/2838-chunk-2
Are you sure you want to change the base?
Conversation
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## issue/2838-chunk-2 #2998 +/- ##
=====================================================
Coverage 39.87% 39.87%
Complexity 2178 2178
=====================================================
Files 659 659
Lines 20435 20435
Branches 1408 1408
=====================================================
Hits 8149 8149
Misses 11839 11839
Partials 447 447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -84,6 +82,7 @@ const Executors = () => { | |||
<ExecutorSelector | |||
executor={executor} | |||
setSelectedExecutor={setSelectedExecutor} | |||
isEEExecutor={executor.executor_type == OPENBAS_TANIUM || executor.executor_type == OPENBAS_CROWDSTRIKE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (for the whole PR): shouldn't we add this as a more generic property somewhere ? Maybe we need to add a isEE propetry in all executors in addition to the executor_type ?
Proposed changes
on install agents :
on endpoint page
Related issues
Further comments