Skip to content

refactor: migrate eslint resolver-oxc to resolver-typescript #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JounQin
Copy link

@JounQin JounQin commented Apr 24, 2025

Proposed changes

As title

Related issues

extracted from #2939

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Just quote from other PRs: SocketDev/socket-cli#386 (comment)

https://github.com/9romise/eslint-import-resolver-oxc#readme is also going to be deprecated soon.

cc @antoinemzs @savacano28 @RomuDeuxfois

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.09%. Comparing base (92441bc) to head (72e67d0).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3030   +/-   ##
=========================================
  Coverage     41.09%   41.09%           
  Complexity     2330     2330           
=========================================
  Files           691      691           
  Lines         21226    21226           
  Branches       1446     1446           
=========================================
  Hits           8723     8723           
  Misses        12010    12010           
  Partials        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JounQin JounQin force-pushed the chore/import-resolver branch from b0ab2d5 to 72e67d0 Compare May 5, 2025 10:11
@antoinemzs
Copy link
Contributor

Hi @JounQin, as with the parent PR, the team's feedback is that the current setup works for us at the moment. Thanks again for your time and sorry this didn't work out this time. Do feel free to come back in the future if you wish to help! Our community on Slack is very active and we can discuss in advance what areas are of greater priority to improve. Cheers!

@antoinemzs antoinemzs closed this May 15, 2025
@JounQin
Copy link
Author

JounQin commented May 15, 2025

@antoinemzs OK... Although it's a bit unexpected, https://github.com/9romise/eslint-import-resolver-oxc#readme, eslint-import-resolver-oxc will be deprecated soon FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants