[Feature] Refactor FMP#7217
Merged
Merged
Conversation
piiq
reviewed
Oct 3, 2025
piiq
left a comment
Member
There was a problem hiding this comment.
Wow, this is a very big PR. I'm ±half way through it, and I thought that I leave the comment dump while the other half is still being read out.
The biggest question/concern/risk I want to ask about is the widespread changes to the standard models and their impact on downstream extensions. Will these changes be breaking? If yes will this only be released with the major version?
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| import pytest # noqa: F401 |
Member
There was a problem hiding this comment.
The rationale for this import to be here is the TIL moment for me.
piiq
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors all functions in the FMP provider extension to use the new FMP API. There are a lot of files touched, and it comes with breaking changes, some removals, and some additions. All FMP parameter and response models have been updated to reflect any schema changes made by FMP.
Some items removed:
obb.equity.fundamental.multiples: This is a duplicate ofmetrics, which is also used by other providers.CompanyOverview: This was not used, and is redundant. The same asEquityProfile.obb.etf.holdings_date: No longer necessary.Some items created:
obb.equity.fundamental.esg_scoreobb.etf.nport_disclosure: Migratessec, and the historical part offmp, frometf.holdings.obb.equity.discovery.gainersobb.equity.discovery.losersobb.equity.discover.activeSome parameter changes:
obb.equity.fundamental.metrics&.ratios:ttmparameter with choices:[include', 'exclude', 'only']. Default isonly, and this setting overrides thelimitandperiodparameters.obb.news.world:topicparameter with choices:['fmp_articles', 'general', 'press_releases', 'stocks', 'forex', 'crypto']obb.equity.price.historical:adjustmentwith choices:['splits_only', 'splits_and_dividends', 'unadjusted']Additional changes:
openbb_core.provider.utils.amake_requestsconftest.pythat was removing the static assets. This now fails with a message that can be ignored when running the tests locally.OBBject. If so, use the model name that is attached to this.