[Feature] openbb-sec: Custom HTML2Markdown Conversion#7361
Open
deeleeramone wants to merge 15 commits intodevelopfrom
Open
[Feature] openbb-sec: Custom HTML2Markdown Conversion#7361deeleeramone wants to merge 15 commits intodevelopfrom
openbb-sec: Custom HTML2Markdown Conversion#7361deeleeramone wants to merge 15 commits intodevelopfrom
Conversation
piiq
reviewed
Feb 18, 2026
openbb_platform/providers/sec/openbb_sec/utils/html2markdown.py
Outdated
Show resolved
Hide resolved
piiq
requested changes
Feb 18, 2026
Member
piiq
left a comment
There was a problem hiding this comment.
To make this readable/understandable by both humans and AI I suggest we split the huge converter function apart. I understand the complexity of what it's doing, but having that function be that large is a risk it won't be understood or read correctly by any party reading it
Contributor
Author
|
@piiq, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
secprovider to use a custom HTML -> Markdown converter instead of relying on multiple libraries as strategies and cleaning up after them.It removes dependencies:
The new module,
openbb_sec.utils.html2markdown.html_to_markdown, is geared specifically for SEC HTML content. It has a much higher success rate - especially where table extraction is concerned - and handles a number of scenarios and filing formats. The existing,obb.equity.fundamental.management_discussion_analysis(), is also better equipped to handle more scenarios:You can A/B this against the existing (use
include_tables=True) with symbols such as: