Use FST instead of Trie for consuming less memory #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
upodesh
to use FST instead of Trie which significantly reduces the amount of memory consumption (from 140MB to 2MB), a 98.57% reduction! 🎉But the runtime performance gets a hit, but I think we can bear this tradeoff in the long run.
But the fst version of upodesh is still significantly faster than the regex-based implementation!
cc @gulshan @mugli
Closes #3