Skip to content

refactor(UBFFmpegVideoEncoder): Use avcodec_get_supported_config #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vekhir wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor(UBFFmpegVideoEncoder): Use avcodec_get_supported_config #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/podcast/ffmpeg/UBFFmpegVideoEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,19 @@ bool UBFFmpegVideoEncoder::init()
}

c->bit_rate = 96000;
c->sample_fmt = audioCodec->sample_fmts ? audioCodec->sample_fmts[0] : AV_SAMPLE_FMT_FLTP;// FLTP by default for AAC

const AVSampleFormat* sample_fmts;
#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(61, 19, 100)
sample_fmts = audioCodec->sample_fmts;
#else
int err = avcodec_get_supported_config(nullptr, audioCodec, AV_CODEC_CONFIG_SAMPLE_FORMAT, 0, (const void**)&sample_fmts, nullptr);
if (err) {
setLastErrorMessage("Could not get supported sample formats");
return false;
}
#endif
c->sample_fmt = sample_fmts ? sample_fmts[0] : AV_SAMPLE_FMT_FLTP;// FLTP by default for AAC

c->sample_rate = mAudioSampleRate;

#if LIBAVUTIL_VERSION_INT < AV_VERSION_INT(57, 25, 100)
Expand Down