Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.02%
==========================================
Files 629 629
Lines 46733 46737 +4
Branches 755 755
==========================================
+ Hits 35911 35925 +14
+ Misses 10739 10729 -10
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanmelt
left a comment
ryanmelt
left a comment
There was a problem hiding this comment.
Needs merge main, and fix to playwright.sh?
playwright/package.json
Outdated
| "test:parallel": "playwright test ./tests/**/*.p.spec.ts --project=chromium", | ||
| "test:serial": "playwright test ./tests/**/*.s.spec.ts --project=chromium --workers=1", | ||
| "test:enterprise": "ENTERPRISE=1 playwright test ./tests/enterprise/*.spec.ts --project=chromium --workers=1", | ||
| "test:keycloak": "playwright test ./tests/**/*.p.spec.ts --project=keycloak || playwright test ./tests/**/*.s.spec.ts --project=keycloak --workers=1", |
There was a problem hiding this comment.
What's up with the new keycloak project?
There was a problem hiding this comment.
It's part of the aws testing: https://github.com/OpenC3/cosmos/blob/main/playwright/playwright.sh#L52
| .fill(format(start, 'HH:mm:ss')) | ||
| await page | ||
| .locator('[data-test=end-date] input') | ||
| .fill(format(date, 'yyyy-MM-dd')) |
There was a problem hiding this comment.
I've seen this particular failure a few times now so good to merge and fix
|
|
||
| run-enterprise ) | ||
| yarn test:enterprise | ||
|
|
otherwise, these could fail and the gh action will still pass as long as the serial tests pass
|
3 participants
No description provided.