Skip to content

Load enterprise APIs#1949

Merged
jmthomas merged 7 commits intomainfrom
apis
May 7, 2025
Merged

Load enterprise APIs#1949
jmthomas merged 7 commits intomainfrom
apis

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Mar 7, 2025 •
edited
Loading

I'd like to add the new autonomic APIs before merging

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (a6bbe15) to head (813dcaa).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
+ Coverage   78.02%   78.04%   +0.02%     
==========================================
  Files         631      631              
  Lines       47530    47535       +5     
  Branches      754      754              
==========================================
+ Hits        37085    37101      +16     
+ Misses      10362    10351      -11     
  Partials       83       83
Flag Coverage Δ
python 84.12% <ø> (+0.06%) ⬆️
ruby-api 58.81% <ø> (ø)
ruby-backend 82.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas requested review from ryan-pratt and ryanmelt March 25, 2025 15:51
ryanmelt
ryanmelt requested changes Mar 27, 2025
View reviewed changes
openc3/python/openc3/api/__init__.py
from .target_api import *
from .tlm_api import *
try:
from openc3enterprise.api.cmd_authority_api import *
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python autonomic api missing.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ryanmelt
ryanmelt requested changes May 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide to do the autonomic api differently. Shouldn't it be removed here now?

@jmthomas
Copy link
Copy Markdown
Member Author

jmthomas commented May 3, 2025

Didn't we decide to do the autonomic api differently. Shouldn't it be removed here now?

Yes, don't merge this

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jmthomas jmthomas merged commit 64b70c5 into main May 7, 2025
29 checks passed
@jmthomas jmthomas deleted the apis branch May 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanmelt ryanmelt ryanmelt approved these changes

@ryan-pratt ryan-pratt ryan-pratt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmthomas @ryanmelt @ryan-pratt