Skip to content

Enforce pointsSaved #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmthomas merged 3 commits into from
Nov 5, 2025
Merged

Enforce pointsSaved #2502

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03f94e1
Enforce pointsSaved
jmthomas Nov 3, 2025
cc6e989
Merge branch 'main' into grapher_saved
jmthomas Nov 5, 2025
71e487d
Add historisis to savePoints, remove old offset-y prop
jmthomas Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Graph.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,6 +1784,15 @@ export default {
}
}
}

// Enforce pointsSaved limit - remove oldest data points if exceeded
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs hysterisis such that every new sample doesn't require rebuilding the array.
Basically check from setting + 100 data points, and then do the cut back to the limit.

if (this.pointsSaved > 0 && this.data[0].length > this.pointsSaved) {
const pointsToRemove = this.data[0].length - this.pointsSaved
for (let j = 0; j < this.data.length; j++) {
this.data[j].splice(0, pointsToRemove)
}
}

// If we weren't passed a startTime notify grapher of our start
if (this.startTime == null && this.data[0][0]) {
let newStartTime = this.data[0][0] * 1_000_000_000
Expand Down
Loading