Skip to content

Enforce pointsSaved #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmthomas merged 3 commits into from
Nov 5, 2025
Merged

Enforce pointsSaved #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03f94e1
Enforce pointsSaved
jmthomas Nov 3, 2025
cc6e989
Merge branch 'main' into grapher_saved
jmthomas Nov 5, 2025
71e487d
Add historisis to savePoints, remove old offset-y prop
jmthomas Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs.openc3.com/static/img/calendar/calendar.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions .../plugins/packages/openc3-cosmos-tool-packetviewer/src/tools/PacketViewer/PacketViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<v-tooltip
:key="`${item.name}-${isPinned(item.name)}`"
:open-delay="600"
bottom
location="bottom"
>
<template #activator="{ props }">
<v-icon
Expand Down Expand Up @@ -97,7 +97,7 @@
/>
</template>
<template #footer.prepend>
<v-tooltip right close-delay="2000">
<v-tooltip location="right" close-delay="2000">
<template #activator="{ props }">
<v-icon v-bind="props" class="info-tooltip">
mdi-information-variant-circle
Expand Down Expand Up @@ -171,7 +171,7 @@
:config-key="configKey"
@success="saveConfiguration"
/>
<v-menu v-model="contextMenuShown" :target="[x, y]" absolute offset-y>
<v-menu v-model="contextMenuShown" :target="[x, y]" absolute>
<v-list>
<v-list-item
v-for="(item, index) in contextMenuOptions"
Expand Down
18 changes: 14 additions & 4 deletions openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Graph.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
/>
</v-row>
<v-row class="my-3">
<v-textarea readonly rows="8" :value="error" />
<v-textarea readonly rows="8" :model-value="error" />
</v-row>
<v-row>
<v-btn block @click="clearErrors"> Clear </v-btn>
Expand All @@ -204,7 +204,6 @@
v-model="editGraphMenu"
:target="[editGraphMenuX, editGraphMenuY]"
absolute
offset-y
>
<v-list>
<v-list-item @click="editGraph = true">
Expand Down Expand Up @@ -232,7 +231,6 @@
v-model="itemMenu"
:target="[itemMenuX, itemMenuY]"
absolute
offset-y
>
<v-list nav density="compact">
<v-list-subheader>
Expand Down Expand Up @@ -267,7 +265,6 @@
v-model="legendMenu"
:target="[legendMenuX, legendMenuY]"
absolute
offset-y
>
<v-list>
<v-list-item @click="moveLegend('top')">
Expand Down Expand Up @@ -1784,6 +1781,19 @@ export default {
}
}
}

// Enforce pointsSaved limit - remove oldest data points if exceeded
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs hysterisis such that every new sample doesn't require rebuilding the array.
Basically check from setting + 100 data points, and then do the cut back to the limit.

// Add 300 point buffer to avoid removing points too often
if (
this.pointsSaved > 0 &&
this.data[0].length > this.pointsSaved + 300
) {
const pointsToRemove = this.data[0].length - this.pointsSaved
for (let j = 0; j < this.data.length; j++) {
this.data[j].splice(0, pointsToRemove)
}
}

// If we weren't passed a startTime notify grapher of our start
if (this.startTime == null && this.data[0][0]) {
let newStartTime = this.data[0][0] * 1_000_000_000
Expand Down
Loading