Skip to content

Fix CmdSender binary commands #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmthomas merged 7 commits into from
Dec 9, 2025
Merged

Fix CmdSender binary commands #2606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72f86ec
Fix CmdSender binary commands
jmthomas Dec 8, 2025
4d831f8
Quote playwright package.json command
jmthomas Dec 9, 2025
dd5f308
Enable all playwright tests
jmthomas Dec 9, 2025
91ad96b
Fix playwright
jmthomas Dec 9, 2025
49a0221
Fix playwright
jmthomas Dec 9, 2025
7299417
Fix bucket explorer playwright
jmthomas Dec 9, 2025
61a8612
Update playwright utility
jmthomas Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/CommandEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,11 @@ export default {
if (parameter.format_string && parameter.default) {
val = sprintf(parameter.format_string, parameter.default)
}
if (Object.prototype.toString.call(val).slice(8, -1) === 'Object') {
val = JSON.stringify(val).replace(/\\n/g, '')
if (
Object.prototype.toString.call(val).slice(8, -1) ===
'Object'
) {
val = this.convertToString(val)
}
let range = 'N/A'
if (
Expand All @@ -275,12 +278,10 @@ export default {
) {
if (parameter.data_type === 'FLOAT') {
if (parameter.minimum < -1e6) {
parameter.minimum =
parameter.minimum.toExponential(3)
parameter.minimum = parameter.minimum.toExponential(3)
}
if (parameter.maximum > 1e6) {
parameter.maximum =
parameter.maximum.toExponential(3)
parameter.maximum = parameter.maximum.toExponential(3)
}
}
range = `${parameter.minimum}..${parameter.maximum}`
Expand Down
3 changes: 3 additions & 0 deletions openc3-cosmos-init/plugins/packages/openc3-vue-common/src/util/cmdUtilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ export default {
}
} else if (value.json_class === 'Float' && value.raw) {
returnValue = value.raw
} else {
// For other objects, use JSON.stringify as a fallback
returnValue = JSON.stringify(value).replace(/\\n/g, '')
}
} else {
returnValue = String(value)
Expand Down
2 changes: 1 addition & 1 deletion playwright/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "OpenC3 integration testing",
"scripts": {
"test": "pnpm test:parallel --quiet && pnpm test:serial --quiet",
"test:parallel": "playwright test ./tests/**/*.p.spec.ts --project=chromium",
"test:parallel": "playwright test ./tests/*.p.spec.ts --project=chromium && playwright test ./tests/**/*.p.spec.ts --project=chromium",
"test:serial": "playwright test ./tests/**/*.s.spec.ts --project=chromium --workers=1",
"test:enterprise": "ENTERPRISE=1 playwright test ./tests/enterprise/*.spec.ts --project=chromium --workers=1",
"test:keycloak": "ENTERPRISE=1 playwright test ./tests/keycloak.setup.ts --workers=1",
Expand Down
163 changes: 64 additions & 99 deletions playwright/tests/bucket-explorer.p.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,19 @@
await page.getByText('config').click()
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2F/)
await page.getByRole('cell', { name: 'DEFAULT' }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ DEFAULT /',
)
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2FDEFAULT%2F/)
await page.getByRole('cell', { name: 'targets', exact: true }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ DEFAULT / targets /',
)
await expect(page).toHaveURL(
/.*\/tools\/bucketexplorer\/config%2FDEFAULT%2Ftargets%2F/,
)
await page.getByRole('cell', { name: 'INST', exact: true }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ DEFAULT / targets / INST /',
)
await expect(page).toHaveURL(
Expand All @@ -71,19 +71,19 @@
)

await page.locator('[data-test="be-nav-back"]').click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ DEFAULT / targets /',
)
await expect(page).toHaveURL(
/.*\/tools\/bucketexplorer\/config%2FDEFAULT%2Ftargets%2F/,
)
await page.locator('[data-test="be-nav-back"]').click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ DEFAULT /',
)
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2FDEFAULT%2F/)
await page.locator('[data-test="be-nav-back"]').click()
await expect(page.locator('[data-test="file-path"]')).toHaveText('/')

Check failure on line 86 in playwright/tests/bucket-explorer.p.spec.ts

View workflow job for this annotation

GitHub Actions / openc3-build-test

[chromium] › tests/bucket-explorer.p.spec.ts:27:5 › navigate config bucket 

  1) [chromium] › tests/bucket-explorer.p.spec.ts:27:5 › navigate config bucket ────────────────────
    Error: expect(locator).toHaveText(expected) failed

    Locator:  locator('[data-test="file-path"]')
    Expected: "/"
    Received: " / DEFAULT / "
    Timeout:  10000ms

    Call log:
      - Expect "toHaveText" with timeout 10000ms
      - waiting for locator('[data-test="file-path"]')
        14 × locator resolved to <div data-v-73b5c6d5="" data-test="file-path" class=".text-body-1 ma-2 font-size">…</div>
           - unexpected value " / DEFAULT / "


      84 |   await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2FDEFAULT%2F/)
      85 |   await page.locator('[data-test="be-nav-back"]').click()
    > 86 |   await expect(page.locator('[data-test="file-path"]')).toHaveText('/')
         |                                                         ^
      87 |   await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2F/)
      88 |   // Back again just to show that doesn't break things
      89 |   await page.locator('[data-test="be-nav-back"]').click()
        at /home/runner/work/cosmos/cosmos/playwright/tests/bucket-explorer.p.spec.ts:86:57
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2F/)
// Back again just to show that doesn't break things
await page.locator('[data-test="be-nav-back"]').click()
Expand All @@ -96,7 +96,7 @@
// Note the URL is prefixed with %2F, i.e. '/'
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/%2Fgems%2F/)
await page.getByRole('cell', { name: 'cosmoscache' }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ cosmoscache /',
)
await expect(page).toHaveURL(
Expand All @@ -106,11 +106,11 @@
await page.locator('[data-test="search-input"] input').fill('bucket')
await expect(page.locator('tbody > tr')).toHaveCount(1)
// Download the file
await utils.download(page, 'tbody > tr [data-test="download-file"]')
await utils.download(page, 'tbody > tr [data-test="download-file"] >> nth=0')

// Reload and ensure we get to the same place
await page.reload()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
await expect(page.locator('[data-test="file-path"]')).toContainText(
'/ cosmoscache /',
)
await expect(page).toHaveURL(
Expand All @@ -120,7 +120,8 @@
await expect(page.locator('tbody > tr')).toHaveCount(1)
})

test('direct URLs', async ({ page }) => {
test('direct URLs', async ({ page, utils }) => {
await utils.sleep(500) // Wait for the app to be ready
// Verify using slashes rather than %2F works
await page.goto('/tools/bucketexplorer/config%2FDEFAULT%2Ftargets%2F')
await expect(page.locator('.v-app-bar')).toContainText('Bucket Explorer')
Expand Down Expand Up @@ -152,7 +153,7 @@
await expect(page.locator('pre')).toContainText('create_timeline')
await page.getByRole('button', { name: 'Ok' }).click()
await page.locator('[data-test="search-input"] input').fill('')
await page.getByText('/ INST').click()
await page.getByText('INST', { exact: true }).click()
await utils.sleep(500) // Allow the page to render
await page.locator('[data-test="search-input"] input').fill('target.txt')
await page.locator('[data-test="view-file"]').first().click()
Expand All @@ -161,32 +162,38 @@
})

test('upload and delete', async ({ page, utils }) => {
const randomDir = 'tmp_' + `${Math.random()}`.substring(2)
// Create a file so we have something in __TEMP__
await page.goto('/tools/scriptrunner')
await expect(page.locator('.v-app-bar')).toContainText('Script Runner')
await page.locator('[data-test=script-runner-file]').click()
await page.locator('text=New File').click()
await expect(page.locator('textarea')).toHaveText('')
await page.locator('textarea').fill(`print('hello world')`)
await page.locator('[data-test=script-runner-file]').click()
await page.locator('[data-test=start-button]').click()
await expect(page.locator('[data-test=state] input')).toHaveValue(
'completed',
{
timeout: 30000,
},
)

await page.goto('/tools/bucketexplorer')
await page.getByText('config').click()
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/config%2F/)
await expect(page.locator('[data-test="file-path"]')).toHaveText('/')
await page.getByRole('cell', { name: 'DEFAULT' }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
'/ DEFAULT /',
)

// Upload something to make sure the tmp dir exists
await expect(page.getByLabel('prepended action')).toBeVisible()
const [fileChooser1] = await Promise.all([
page.waitForEvent('filechooser'),
await page.getByLabel('prepended action').click(),
])
await fileChooser1.setFiles('package.json')
await page
.locator('[data-test="upload-file-path"] input')
.fill(`DEFAULT/${randomDir}/tmp.json`)
await page.locator('[data-test="upload-file-submit-btn"]').click()

await page.getByRole('cell', { name: 'targets_modified' }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
`/ DEFAULT / ${randomDir} /`,
'/ DEFAULT / targets_modified /',
)
await page.getByRole('cell', { name: '__TEMP__' }).click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
'/ DEFAULT / targets_modified / __TEMP__ /',
)
await page.locator('tbody> tr').first().waitFor()
let count = await page.locator('tbody > tr').count()

// Note that Promise.all prevents a race condition
// between clicking and waiting for the file chooser.
Expand All @@ -200,49 +207,11 @@
await fileChooser.setFiles('package.json')
await page.locator('[data-test="upload-file-submit-btn"]').click()

await expect
.poll(() => page.locator('tbody > tr').count(), { timeout: 10000 })
.toBeGreaterThanOrEqual(count + 1)
await expect(page.getByRole('cell', { name: 'package.json' })).toBeVisible()
await page
.locator('tr:has-text("package.json") [data-test="delete-file"]')
.click()
await page.locator('[data-test="confirm-dialog-delete"]').click()
await expect
.poll(() => page.locator('tbody > tr').count(), { timeout: 10000 })
.toBeGreaterThanOrEqual(count)

// Note that Promise.all prevents a race condition
// between clicking and waiting for the file chooser.
await expect(page.getByLabel('prepended action')).toBeVisible()
const [fileChooser2] = await Promise.all([
// It is important to call waitForEvent before click to set up waiting.
page.waitForEvent('filechooser'),
// Opens the file chooser.
await page.getByLabel('prepended action').click(),
])
await fileChooser2.setFiles('package.json')
await page
.locator('[data-test="upload-file-path"] input')
.fill(`DEFAULT/${randomDir}/TEST/tmp/myfile.json`)
await page.locator('[data-test="upload-file-submit-btn"]').click()
await expect(page.locator('[data-test="file-path"]')).toHaveText(
`/ DEFAULT / ${randomDir} / TEST / tmp /`,
)
await page
.locator('tr:has-text("myfile.json") [data-test="delete-file"]')
.click()
await page.locator('[data-test="confirm-dialog-delete"]').click()

// Cleanup tmp.json
await page.getByText('logs').click()
await page.getByText('config').click()
await page.getByRole('cell', { name: 'DEFAULT' }).click()
await page.getByRole('cell', { name: randomDir }).click()
await page
.locator('tr:has-text("tmp.json") [data-test="delete-file"]')
.click()
await page.locator('[data-test="confirm-dialog-delete"]').click()
})

test('navigate logs and tools bucket', async ({ page, utils }) => {
Expand Down Expand Up @@ -284,7 +253,7 @@
await page.getByText('tools').click()
await expect(page).toHaveURL(/.*\/tools\/bucketexplorer\/tools%2F/)
if (process.env.ENTERPRISE === '1') {
await expect(page.locator('tbody > tr')).toHaveCount(20)
await expect(page.locator('tbody > tr')).toHaveCount(23)
} else {
await expect(page.locator('tbody > tr')).toHaveCount(17)
}
Expand All @@ -296,54 +265,57 @@
toolPath,
context,
}) => {
const randomDir = 'tmp_' + `${Math.random()}`.substring(2)
// Upload something from the first tab to make sure the tmp dir exists
await page.getByText('config').click()
await expect(page.getByLabel('prepended action')).toBeVisible()
const [fileChooser1] = await Promise.all([
page.waitForEvent('filechooser'),
await page.getByLabel('prepended action').click(),
])
await fileChooser1.setFiles('package.json')
await page
.locator('[data-test="upload-file-path"] input')
.fill(`DEFAULT/${randomDir}/package1.json`)
await page.locator('[data-test="upload-file-submit-btn"]').click()
// Create a file so we have something in __TEMP__
await page.goto('/tools/scriptrunner')
await expect(page.locator('.v-app-bar')).toContainText('Script Runner')
await page.locator('[data-test=script-runner-file]').click()
await page.locator('text=New File').click()
await expect(page.locator('textarea')).toHaveText('')
await page.locator('textarea').fill(`print('hello world')`)
await page.locator('[data-test=start-button]').click()
await expect(page.locator('[data-test=state] input')).toHaveValue(
'completed',
{
timeout: 30000,
},
)

// Open another tab and navigate to the tmp dir
// Open another tab and navigate to the __TEMP__ dir
const pageTwo = await context.newPage()
pageTwo.goto(toolPath)
await pageTwo.getByText('config').click()
await pageTwo.getByRole('cell', { name: 'DEFAULT' }).click()
await pageTwo.getByRole('cell', { name: randomDir }).click()
await pageTwo.getByRole('cell', { name: 'targets_modified' }).click()
await pageTwo.getByRole('cell', { name: '__TEMP__' }).click()

// Set the refresh interval on the second tab to be really slow
await pageTwo.locator('[data-test=bucket-explorer-file]').click()
await pageTwo.locator('[data-test=bucket-explorer-file-options]').click()
await pageTwo
.locator('.v-dialog [data-test=refresh-interval] input')
.fill('1000')
await pageTwo
.locator('.v-dialog [data-test=refresh-interval] input')
.press('Enter')
await pageTwo.locator('.v-dialog').press('Escape')
await pageTwo.getByRole('button', { name: 'Save' }).click()

// Upload a file from the first tab
await page.goto(
'/tools/bucketexplorer/config%2FDEFAULT%2Ftargets_modified%2F__TEMP__%2F',
)
await expect(page.locator('.v-app-bar')).toContainText('Bucket Explorer')
await expect(page.getByLabel('prepended action')).toBeVisible()
const [fileChooser2] = await Promise.all([
const [fileChooser] = await Promise.all([
page.waitForEvent('filechooser'),
await page.getByLabel('prepended action').click(),
])
await fileChooser2.setFiles('package.json')
await fileChooser.setFiles('package.json')
await page
.locator('[data-test="upload-file-path"] input')
.fill(`DEFAULT/${randomDir}/package2.json`)
.fill(`DEFAULT/targets_modified/__TEMP__/refresh_package.json`)
await page.locator('[data-test="upload-file-submit-btn"]').click()

// The second tab shouldn't have refreshed yet, so the file shouldn't be there
await page.locator('tbody> tr').first().waitFor()
await expect(
pageTwo.getByRole('cell', { name: 'package2.json' }),
pageTwo.getByRole('cell', { name: 'refresh_package.json' }),
).not.toBeVisible({ timeout: 10000 })

// Set the refresh interval on the second tab to 1s
Expand All @@ -352,24 +324,17 @@
await pageTwo
.locator('.v-dialog [data-test=refresh-interval] input')
.fill('1')
await pageTwo
.locator('.v-dialog [data-test=refresh-interval] input')
.press('Enter')
await pageTwo.locator('.v-dialog').press('Escape')
await pageTwo.getByRole('button', { name: 'Save' }).click()

// Second tab should auto refresh in 1s and then the file should be there
await page.locator('tbody> tr').first().waitFor()
await expect(
pageTwo.getByRole('cell', { name: 'package2.json' }),
pageTwo.getByRole('cell', { name: 'refresh_package.json' }),
).toBeVisible()

// Cleanup
await page
.locator('tr:has-text("package1.json") [data-test="delete-file"]')
.click()
await page.locator('[data-test="confirm-dialog-delete"]').click()
await page
.locator('tr:has-text("package2.json") [data-test="delete-file"]')
.locator('tr:has-text("refresh_package.json") [data-test="delete-file"]')
.click()
await page.locator('[data-test="confirm-dialog-delete"]').click()
})
Loading
Loading