Skip to content

Printing binary causes SR to not finish #2621#2627

Merged
jmthomas merged 1 commit intoOpenC3:mainfrom
markjmiller:markmiller/2621
Dec 12, 2025
Merged

Printing binary causes SR to not finish #2621#2627
jmthomas merged 1 commit intoOpenC3:mainfrom
markjmiller:markmiller/2621

Conversation

@markjmiller
Copy link
Copy Markdown
Contributor

@markjmiller markjmiller commented Dec 12, 2025

See #2621

Old behavior

The script runner UI hangs like this:
image

New behavior

The script runner UI successfully runs the script with a properly serialized message:
image

Validation

Also tested with known, working script which expectedly has no change in behavior:
image

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.08%. Comparing base (24ca210) to head (751d9ed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage   79.07%   79.08%           
=======================================
  Files         661      661           
  Lines       51990    51990           
  Branches      732      732           
=======================================
+ Hits        41113    41118    +5     
+ Misses      10797    10792    -5     
  Partials       80       80           
Flag Coverage Δ
python 81.07% <ø> (+0.01%) ⬆️
ruby-api 84.43% <ø> (ø)
ruby-backend 82.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas self-requested a review December 12, 2025 22:23
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@jmthomas jmthomas merged commit cb354f7 into OpenC3:main Dec 12, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants