Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
=======================================
Coverage 78.51% 78.52%
=======================================
Files 673 673
Lines 55332 55332
Branches 728 728
=======================================
+ Hits 43445 43449 +4
+ Misses 11809 11805 -4
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyRagan
force-pushed
the
calendar-docs-and-bug-fix
branch
2 times, most recently
from
a6e50c7 to
01a9afc
Compare
EmilyRagan
force-pushed
the
calendar-docs-and-bug-fix
branch
from
01a9afc to
861d01c
Compare
|
| <div v-else-if="kind === 'SCRIPT'" class="ma-3"> | ||
| <script-chooser @file="fileHandler" /> | ||
| <script-chooser | ||
| :model-value="activityData" |
There was a problem hiding this comment.
Ah nice. I've noticed this in the past too, thanks! I think it won't handle the case where a script is deleted and then we try to edit it, but if a script that was deleted won't run successfully on calendar so I think it's fine 👍
There was a problem hiding this comment.
Oh I hadn't considered that case -- we can open another issue to handle that particular workflow
3 participants
dataandscopeparameters intocreate_timeline_activityscript function(
scopehas been added since this screenshot was taken)