Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3029 +/- ##
==========================================
+ Coverage 78.26% 78.28% +0.01%
==========================================
Files 673 673
Lines 55238 55263 +25
Branches 728 728
==========================================
+ Hits 43234 43263 +29
+ Misses 11926 11922 -4
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
I assume there is a companion enterprise PR to allow you name the triggers and reactions in the UI?
Yep I see you linked to it |
| def verify_triggers | ||
| # Validate that all triggers exist, but do not persist dependent changes yet. | ||
| # Returns the list of trigger models that need updating. | ||
| def validate_triggers_exist |
There was a problem hiding this comment.
The change below is to ensure that the dependencies are not updated until after the trigger / reaction is created. This prevents an edge case where dependents are defined but the dependency doesn't exist.
|
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
So we're still able to create a unique name but it is fixed. If you want to change it you create a label. Feels like we can remove the name stuff.
| name = hash.delete('name') | ||
| if name.nil? || name.strip.empty? | ||
| name = @model_class.create_unique_name(scope: params[:scope]) | ||
| end |
There was a problem hiding this comment.
Do we need the name stuff anymore now that we're using the label field
2 participants
closes https://github.com/OpenC3/cosmos-enterprise/issues/508
closes https://github.com/OpenC3/cosmos-enterprise/issues/507