Skip to content

Resolve CI lint regressions in CVE-2019-9583 retry path#145

Open
Copilot wants to merge 6 commits intomasterfrom
copilot/fix-ci-workflow-errors
Open

Resolve CI lint regressions in CVE-2019-9583 retry path#145
Copilot wants to merge 6 commits intomasterfrom
copilot/fix-ci-workflow-errors

Conversation

Copy link

Copilot AI commented Mar 22, 2026

The latest workflow runs failed due to XO lint errors introduced in the CVE-2019-9583 hardening changes, not due to test logic regressions. This update keeps the retry behavior intact while aligning the implementation with repository lint rules.

  • Lint-compliant retry error code lookup

    • Switched retryable error code storage from Array to Set.
    • Replaced .includes(...) with .has(...) to satisfy unicorn/prefer-set-has.
  • Control-flow simplification

    • Removed an unnecessary else branch after early return in the request callback to satisfy no-else-return.
    • Preserved existing behavior for retryable errors and vulnerable redirect detection.
const retryableErrorCodes = new Set(['ECONNRESET', 'ETIMEDOUT', 'ESOCKETTIMEDOUT']);

if (error) {
  return retryCallback(error);
}

if (typeof (response.headers.location) !== 'undefined' &&
    response.headers.location.includes('sid=@')) {
  return retryCallback(new Error(...));
}

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI changed the title Identifying and fixing CI workflow errors Stabilize CI by hardening CVE-2019-9583 URL scan against transient socket failures Mar 22, 2026
Copilot AI requested a review from jens-maus March 22, 2026 21:58
Co-authored-by: jens-maus <5887769+jens-maus@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenCCU/ReGaHss-Test/sessions/8fe8f667-8c90-4ca9-8a38-ab41e375bd73
Copilot AI changed the title Stabilize CI by hardening CVE-2019-9583 URL scan against transient socket failures Resolve CI lint regressions in CVE-2019-9583 retry path Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants