Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@fslds
Copy link

@fslds fslds commented May 4, 2025

Setuptools is defined in the project requirement, but it seems that no code (as it should) relies on setuptools and this is merely a build requirement. As such I have removed it from requirements.txt and setup.cfg.
This change should increase overall compatibility and reduce version conflicts (as I have experienced), without impacting functionality.

Proposed changes

  • Remove setuptools from project requirements.

Related issues

  • n/a

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@fslds fslds marked this pull request as ready for review May 4, 2025 23:46
@fslds fslds changed the title Remove setuptools from project requirements [client] Remove setuptools from project requirements May 5, 2025
@nino-filigran nino-filigran added the community use to identify PR from community label May 9, 2025
@aHenryJard aHenryJard self-assigned this Jun 20, 2025
@helene-nguyen helene-nguyen self-assigned this Jul 1, 2025
@helene-nguyen
Copy link
Member

@fslds Thank you for your contribution !

We work aside to use another tool for package management, for now setuptools here is required in our usages and cannot be removed. I close the PR for now, and I've created an issue to follow the updates: OpenCTI-Platform/opencti#13375

@fslds
Copy link
Author

fslds commented Jul 7, 2025

Ahh that's nice! But I just want to add the problem is not the packaging itself, it is that it ends up being a package dependency, which it shouldn't.

You just make sure setuptools (or whichever build tool) is present when building, worst case a separate requirement group, but not as a part of the main dependencies.

@helene-nguyen
Copy link
Member

@fslds Thank you, we will work on it !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community use to identify PR from community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants