Skip to content

[client] Remove setuptools from project requirements #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fslds
Copy link

@fslds fslds commented May 4, 2025

Setuptools is defined in the project requirement, but it seems that no code (as it should) relies on setuptools and this is merely a build requirement. As such I have removed it from requirements.txt and setup.cfg.
This change should increase overall compatibility and reduce version conflicts (as I have experienced), without impacting functionality.

Proposed changes

  • Remove setuptools from project requirements.

Related issues

  • n/a

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@fslds fslds marked this pull request as ready for review May 4, 2025 23:46
@fslds fslds changed the title Remove setuptools from project requirements [client] Remove setuptools from project requirements May 5, 2025
@nino-filigran nino-filigran added the community use to identify PR from community label May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants