[microsoft-defender-intel] Update connector to be "manager_supported" #5338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powlinett
added
filigran team
Powlinett
requested review from
Kakudou,
Megafredo,
Ninoxe,
helene-nguyen,
jabesq,
mariot and
throuxel
Powlinett
force-pushed
the
feat/4847-migrate-microsoft-defender-intel
branch
from
52b349b to
f05a4c1
Compare
Powlinett
force-pushed
the
feat/4847-migrate-microsoft-defender-intel
branch
2 times, most recently
from
28b43d8 to
d97e74e
Compare
Powlinett
removed
the
do not merge
mariot
previously approved these changes
Dec 24, 2025
Member
There was a problem hiding this comment.
See comments, I will push the changes for:
- Removing "live" as default and update config files
- Fixing url path for
MICROSOFT_DEFENDER_INTEL_RESOURCE_PATHvariable - Regenerating schema
- Fix tests following changes listed above
- Re-order imports and module-level declarations
stream/microsoft-defender-intel/src/microsoft_defender_intel_connector/settings.py
Outdated
Show resolved
Hide resolved
stream/microsoft-defender-intel/src/microsoft_defender_intel_connector/__init__.py
Outdated
Show resolved
Hide resolved
stream/microsoft-defender-intel/src/microsoft_defender_intel_connector/settings.py
Outdated
Show resolved
Hide resolved
jabesq
previously approved these changes
Dec 29, 2025
Member
jabesq
left a comment
jabesq
left a comment
There was a problem hiding this comment.
Tested with docker compose and config.yml
helene-nguyen
added
the
do not merge
Member
|
Do not merge for now until complete functionnal test has been done |
throuxel
previously approved these changes
Dec 31, 2025
throuxel
removed
the
do not merge
throuxel
force-pushed
the
feat/4847-migrate-microsoft-defender-intel
branch
from
838ae10 to
d7ad217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
settings.pyconnector.pymain.pyor__main__.pyRelated issues
Checklist
Further comments
The code needs to be reviewed by two people: one must fix any issue, the other one review the final commits.