Skip to content

[frontend] Detect changes in CK Editor when in Source mode (#8694) #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

Archidoit
Copy link
Member

Proposed changes

In the Content tab of a Container, in the text area to edit an html file, detect changes when in Source mode to be able to save the changes in Source mode.

Related issues

#8694

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Apr 14, 2025
@Archidoit Archidoit self-assigned this Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (e8172c0) to head (87a166d).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10656      +/-   ##
==========================================
- Coverage   65.54%   65.53%   -0.01%     
==========================================
  Files         672      672              
  Lines       66971    66971              
  Branches     7357     7353       -4     
==========================================
- Hits        43894    43889       -5     
- Misses      23077    23082       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The saving works correctly. The UX is not incredible to see that the text is actually saved, but it's not the subject of the bug here

@Archidoit Archidoit merged commit d3e8cb2 into master Apr 22, 2025
9 checks passed
@Archidoit Archidoit deleted the issue/8694 branch April 22, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants