Skip to content

[frontend] Display all filters inline with a single tooltip(#9806) #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Apr 16, 2025

Proposed changes

  • one tooltip
  • refacto filterIconButtonContainer

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe self-assigned this Apr 16, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Apr 16, 2025
@CelineSebe CelineSebe marked this pull request as ready for review April 16, 2025 08:28
@CelineSebe CelineSebe linked an issue Apr 16, 2025 that may be closed by this pull request
@CelineSebe CelineSebe changed the title [frontend] Display all filters inline with one tooltip only (#9806) [frontend] Display all filters inline with a single tooltip(#9806) Apr 16, 2025
@CelineSebe CelineSebe marked this pull request as draft April 16, 2025 12:50
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.65%. Comparing base (2176bb1) to head (834aff8).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10694      +/-   ##
==========================================
+ Coverage   65.54%   65.65%   +0.10%     
==========================================
  Files         672      672              
  Lines       66977    67142     +165     
  Branches     7357     7434      +77     
==========================================
+ Hits        43900    44080     +180     
+ Misses      23077    23062      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display all filters inline with a tooltip
1 participant