Skip to content

[backend] refresh cache for Resolved filters at playbook/stream/trigger update (#10593) #10704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

Archidoit
Copy link
Member

Proposed changes

Fix the cache update for Resolved filters
To fix the issue: after updating a playbook / stream / trigger / connector filters, if the filters contained ids, the playbook / stream / trigger / connector doesn't work anymore (doesn't detect changes concerning the added ids).

Related issues

#10593

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Apr 16, 2025
@Archidoit Archidoit self-assigned this Apr 16, 2025
@Archidoit Archidoit marked this pull request as draft April 16, 2025 16:24
@Archidoit Archidoit linked an issue Apr 16, 2025 that may be closed by this pull request
@Archidoit Archidoit marked this pull request as ready for review April 17, 2025 07:47
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (5a27082) to head (5158820).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...atform/opencti-graphql/src/manager/cacheManager.ts 60.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10704      +/-   ##
==========================================
+ Coverage   65.53%   65.64%   +0.11%     
==========================================
  Files         672      672              
  Lines       66977    67060      +83     
  Branches     7354     7382      +28     
==========================================
+ Hits        43892    44024     +132     
+ Misses      23085    23036      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally for playbooks

@Archidoit Archidoit merged commit 25c85b1 into master Apr 17, 2025
9 checks passed
@Archidoit Archidoit deleted the issue/10593 branch April 17, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playbook not properly matching relationships
3 participants