Skip to content

Conversation

@SarahBocognano
Copy link
Member

Proposed changes

  • The issue was reopen because the enrichment wasn't working correctly with select all. With product @alice-debra et @nino-filigran it was decided to "disable" the enrichment button if no filter is added previously on the select all. (It's working otherwise if select manually)
  • Refactor of this component to use dataTable

Related issues

@SarahBocognano SarahBocognano self-assigned this Dec 29, 2025
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Dec 29, 2025
@Archidoit Archidoit self-assigned this Dec 29, 2025
@Archidoit
Copy link
Member

Too much space at the end of each observable line :
image

@Archidoit
Copy link
Member

With the refacto of the component you did, we loose a functionnality: it's no more possible to easily remove a single observable line

BEFORE
image

NOW
image

@Archidoit
Copy link
Member

Maybe for this part : "it was decided to "disable" the enrichment button if no filter is added previously on the select all. (It's working otherwise if select manually" --> we can add a tooltip on the disabled button, indicating : 'with a select all, you should add an entity type filter on a single entity type to be able to enrich blabla....' or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants