Skip to content

Conversation

@e-kwsm
Copy link
Collaborator

@e-kwsm e-kwsm commented Dec 22, 2025

fix(LammpsDataFormat): enforce right-handed cell

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@e-kwsm e-kwsm added the file-format relevant to IO file formats label Dec 22, 2025
Copy link
Member

@ghutchis ghutchis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - should we check other formats like VASP?

@e-kwsm
Copy link
Collaborator Author

e-kwsm commented Dec 23, 2025

AFAIK other formats than Lammps (and CML?) allow left-handed systems.
#2136 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-format relevant to IO file formats

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants