fix segfault when CILK_ALERT=memory (and that alert is enabled)#39
Merged
kyle-singer merged 1 commit intoOpenCilk:devfrom Jan 15, 2025
Merged
Conversation
kyle-singer
force-pushed
the
fix-memory-alert-on-start
branch
from
d617409 to
b2c3b88
Compare
kyle-singer
force-pushed
the
fix-memory-alert-on-start
branch
from
b2c3b88 to
88d307e
Compare
neboat
pushed a commit
that referenced
this pull request
May 8, 2025
…ug.h) (#39) Co-authored-by: Kyle Singer <kdsinger@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the constructor function in init.c, __default_cilkrts_startup -> __cilkrts_startup -> Closure_create, the runtime currently segfaults when CILK_ALERT=memory because all worker local states are assumed to be valid if the worker pointer itself is valid when cheetah is dumping memory stats. At this point in the code, however, only worker 0 has a valid local_state pointer.