Reject oversized request parameters at authorization endpoint with HTTP 414#322
Merged
Reject oversized request parameters at authorization endpoint with HTTP 414#322
Conversation
Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
… and remove reflection from tests Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Check parameter size to avoid heap problems
Reject oversized query parameters at authorization endpoint with HTTP 414
Feb 17, 2026
Member
|
@copilot The validation must also take place for a POST authorization request. Change the |
…both GET and POST requests Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Contributor
Author
Updated the validation to check the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…cation Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Copilot
AI
changed the title
Reject oversized query parameters at authorization endpoint with HTTP 414
Reject oversized request parameters at authorization endpoint with HTTP 414
Feb 17, 2026
Member
|
@copilot What is your opinion on making the following change? |
Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Contributor
Author
... Good suggestion! Using URL-encoded size is more accurate since it matches the actual byte size when parameters are transmitted in URLs or included in response headers (which is what caused the original The URL encoding accounts for special characters that expand (e.g., space → Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…rge parameters Co-authored-by: oharsta <530657+oharsta@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
============================================
+ Coverage 89.93% 90.00% +0.07%
- Complexity 665 673 +8
============================================
Files 86 87 +1
Lines 2424 2442 +18
Branches 276 277 +1
============================================
+ Hits 2180 2198 +18
Misses 129 129
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production incident: authorization requests with malformed parameters (e.g.,
scope=openid+openid+openid...repeated 1000+ times) proceeded through authentication but failed post-auth withHeadersTooLargeExceptiondue to response headers exceeding buffer limits.Changes
UriTooLongExceptionreturns HTTP 414 statusmax-query-param-sizeproperty inapplication.ymlImplementation
Validation occurs at the start of
AuthorizationEndpoint.authorize(), rejecting malformed requests before SAML authentication. The implementation validates the@RequestParam MultiValueMap<String, String> parametersdirectly, ensuring both GET and POST authorization requests are protected. The URL-encoded size calculation ensures accurate measurement of the actual transmitted size, including expansion of special characters (e.g., space →%20), which is what causes theHeadersTooLargeExceptionin production. The incremental calculation with early exit optimization prevents heap issues from the validation itself.Original prompt
This section details on the original issue you should resolve
<issue_title>Check parameter size to avoid heap problems</issue_title>
<issue_description>In production, we saw the following authn request: