Upgrade packages & make compatible with Symfony 7.4 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the pipeline was red because there were some phpstan errors. Also phpmd complained about unused private fields, but they were not unused...
`slevomat/coding-standard` `surfnet/stepup-bundle` `surfnet/stepup-saml-bundle` and requirements. Remove phpcpd as it is abandoned.
MKodde
approved these changes
Jan 15, 2026
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Feel free to merge it like this. I did find some small nitpicks and suggestions. The most impactful one would be to remove all redundant @var phpdoc blocks in the code. But feel free to leave them!
src/Surfnet/StepupMiddlewareClientBundle/Identity/Dto/RaSecondFactorExportCollection.php
Outdated
Show resolved
Hide resolved
- Add docheader check - Fix docheader - Upgrade phpstan & fix issues - Add rector
johanib
force-pushed
the
feature/update_sf74
branch
from
79f9f91 to
4e51326
Compare
Have rector cleanup all redundant typehints in comments where the type is already specified by a native php hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.