Use entitlement when no query parameter is set #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
approved these changes
Nov 25, 2024
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Approved with a suggestion to make the logical expression more expressive
src/Surfnet/StepupSelfService/SelfServiceBundle/Service/ActivationFlowService.php
Outdated
Show resolved
Hide resolved
This change will use the only activation flow that's allowed through the entitlement SAML attribute when no preferred activation flow is set with a query parameter. This was encountered while enhancing the Behat tests with the ability to add SAML-attributes.
pablothedude
force-pushed
the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
from
2ae0de9 to
3b130f8
Compare
pablothedude
deleted the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will use the only activation flow that's allowed through the entitlement SAML attribute when no preferred activation flow is set with a query parameter.
This was encountered while enhancing the Behat tests with the ability to add SAML-attributes.