Redirect to initial uri after successful login #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/redirect-to-initial-uri-after-successful-login
branch
from
b6822a3 to
9c4ebcd
Compare
pablothedude
force-pushed
the
feature/redirect-to-initial-uri-after-successful-login
branch
from
361ebf4 to
963b599
Compare
johanib
reviewed
Dec 5, 2024
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
Is there no test coverage?
Did you come up with this? Or did you reverse engineer from before the symfony upgrade?
...lfService/SelfServiceBundle/Security/Authentication/Handler/AuthenticationSuccessHandler.php
Show resolved
Hide resolved
This will fix a bug when a user verifies a token when not logged into selfservice because the initial url is not stores in the session to be redirected to after the login.
pablothedude
force-pushed
the
feature/redirect-to-initial-uri-after-successful-login
branch
from
963b599 to
c896263
Compare
Contributor
Author
I've implemented it with the new setup in the SAML-bundle. Something alike seemed to be handled in a listener before the upgrade but a great part of that logic was moved to that bundle in the meantime. I've added a test in Behat, see the link above. |
johanib
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#440
Also added a test in devconf: OpenConext/OpenConext-devconf#22