Add option to disable bit rate switching for socket can #373
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in CAN-FD mode, but with same nominal and data baudrate, BRS bit has to remain at zero. That indicates that there is no bitrate switch happening for data and data is transmitted at same speed.
LukasLendvorsky
force-pushed
the
disable_brs
branch
from
1d0c969 to
f23e13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in CAN-FD mode, but with same nominal and data baudrate (just 64B data payload, but without transmitting data faster), BRS bit has to remain at zero. That indicates that there is no bitrate switch happening for data and data is transmitted at same speed.
If I send message with BRS=1, even with data & nominal speed configured the same, I get framing errors on the bus. Even single message like this kills my whole bus.
This introduces option to do that via uavcan.udp.disable_brs set to true, or determines this automatically when uavcan.udp.bitrate indicates same bitrate for header & data.