Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mesh decimation stage to address issue #23 (later LODs not further reducing) by refactoring how simplification parameters are passed into MeshDecimatorCore, while also removing unused vertex-attribute code paths.
Changes:
- Replace legacy decimator flags with a new
SimplificationOptionsconfiguration object passed fromDecimationStage. - Modify
FastQuadricMeshSimplificationto useOptions, add curvature-weighted error, and change attribute blending behavior. - Remove dead code for tangents/bone weights in
MeshDecimatorCore.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Obj2Tiles/Stages/DecimationStage.cs | Switches decimation setup to SimplificationOptions and adds a warning when reduction is minimal. |
| MeshDecimatorCore/SimplificationOptions.cs | Introduces a new options struct to configure simplification behavior. |
| MeshDecimatorCore/Algorithms/DecimationAlgorithm.cs | Replaces PreserveBorders with an Options property to carry simplification settings. |
| MeshDecimatorCore/Algorithms/FastQuadricMeshSimplification.cs | Refactors algorithm behavior to read from Options, adds curvature handling, and changes vertex attribute interpolation strategy. |
| MeshDecimatorCore/Mesh.cs | Removes tangents/bone-weight support and related recalculation logic. |
| MeshDecimatorCore/BoneWeight.cs | Removes unused bone-weight type as part of dead-code cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23