io.openems.edge.bridge.modbus.ascii - adding support for Modbus/ASCII over serial#3632
Open
janklostermann wants to merge 12 commits intoOpenEMS:developfrom
Open
io.openems.edge.bridge.modbus.ascii - adding support for Modbus/ASCII over serial#3632janklostermann wants to merge 12 commits intoOpenEMS:developfrom
janklostermann wants to merge 12 commits intoOpenEMS:developfrom
Conversation
…existing Modbus/RTU bridge. co-authored by: claude@anthropic.com
…i protocol (`>` instead of `:` to start message when responding)
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (52.34%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3632 +/- ##
=============================================
+ Coverage 58.52% 58.56% +0.05%
Complexity 104 104
=============================================
Files 3095 3099 +4
Lines 134205 134398 +193
Branches 9870 9881 +11
=============================================
+ Hits 78528 78695 +167
- Misses 52761 52774 +13
- Partials 2916 2929 +13 🚀 New features to boost your workflow:
|
… device interfaces
Contributor
Author
|
Sorry, cbd5948 was definitely premature. I am going to fix the issues and integrate some further improvements of the PR. I will come back soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Modbus/ASCII bridge to openems to support devices that communicate through this protocol via a serial port (one example would be the ABL eMH1).
It is implemented as a separate component to not interfere with the existing modbus bridge, which implements the Modbus/RTU protocol over serial under the name BridgeModbusSerialImpl.java.
It might be a good idea to integrate this code into the
io.openems.edge.bridge.modbuscomponent. There could be even an abstraction be made to separate-out common code for the serial RTU and ASCII implementations (both usej2modfor the heavy-lifting) and rename the currentSerialtoSerialRtu.If you wish I can adjust this PR accordingly.
(I chose the path of separating them to simplify evaluation and merging, and avoid the risk of mixing things up in the field-proven modbus bridge.)
Unfortunatetely I was not able to bring this component into the section
device interfacesalongside the other bridges. I would be happy to fix this if I knew how.