Sdk 3.0.0#65
Conversation
|
Build output available: |
|
Kconfig.defaults has been added instead of overlay-unicast_server.conf. Build pipeline is working now. |
cadivus
left a comment
cadivus
left a comment
There was a problem hiding this comment.
I can't press approve since I created the PR, but looks good to me (besides the nitpick).
|
Build in VSCode works in a new clone without setting anything |
There was a problem hiding this comment.
Pull Request Overview
This draft PR updates the sensor SDK to version 3.0.0 for running the pipeline. The key changes include modifying sensor sample counting logic in BoneConduction, updating error checking for message queues across sensors, and adjusting DTS and board initialization settings for load switches.
Reviewed Changes
Copilot reviewed 29 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SensorManager/BoneConduction.h | Changed _sample_count type from int to float and added _last_time_stamp. |
| src/SensorManager/BoneConduction.cpp | Updated sample accumulation using elapsed time and refined error checks. |
| src/SensorManager/Baro.cpp | Modified k_msgq_put error check condition. |
| src/SensorManager/BMA580/BMA580_Sensor.h | Increased watermark level from 64 to 128. |
| src/SensorManager/BMA580/BMA580_Sensor.cpp | Changed noise_mode value from LOWER_POWER to LOWER_NOISE. |
| src/SD_Card/SDLogger/SDLogger.cpp | Updated error check in k_msgq_put condition for sensor stream. |
| sample.yaml | Updated integration platforms and allowed platform settings. |
| dts/bindings/ti,bq25120a.yaml | Removed redundant lsctrl-gpios and added child-binding comments. |
| dts/bindings/load-switch.yaml | Added new property 'power-delay-us'. |
| boards/teco/openearable_v2/openearable_v2_nrf5340_cpuapp.yml | Added sysbuild parameter for openearable_v2 platform. |
| boards/teco/openearable_v2/board_init.c | Updated DTS node usage for load_switch_3_3 and integrated delay property. |
Files not reviewed (9)
- CMakeLists.txt: Language not supported
- Kconfig: Language not supported
- Kconfig.defaults: Language not supported
- boards/teco/openearable_v2/Kconfig.defconfig: Language not supported
- boards/teco/openearable_v2/board.cmake: Language not supported
- boards/teco/openearable_v2/openearable_v2_nrf5340_cpuapp_common.dts: Language not supported
- dts/bindings/analog,ssm6515.yaml: Language not supported
- prj.conf: Language not supported
- prj_fota.conf: Language not supported
Comments suppressed due to low confidence (5)
src/SensorManager/BoneConduction.h:47
- Changing _sample_count from an int to a float may impact any arithmetic comparisons or assignments made elsewhere. Please verify that all operations using _sample_count properly handle the float type.
float _sample_count = 0;
src/SensorManager/BoneConduction.cpp:77
- Switching from a specific check (ret == -EAGAIN) to a general if (ret) requires confirmation that all non-zero return values indicate an error. Consider double-checking that this change correctly handles the intended error condition.
if (ret) {
src/SensorManager/Baro.cpp:52
- Ensure that replacing the condition 'ret == -EAGAIN' with a general 'if (ret)' accurately captures the intended failure mode for the sensor message queue.
if (ret) {
src/SD_Card/SDLogger/SDLogger.cpp:48
- Review the updated error-checking logic to ensure that a general non-zero return value from k_msgq_put is the correct indicator for a full queue across all contexts.
if (ret) {
boards/teco/openearable_v2/board_init.c:17
- Changing the retrieval of load_switch_3_3_id to use DT_CHILD may affect downstream usage. Please ensure that this DTS change matches the expected hardware configuration.
#define load_switch_3_3_id DT_CHILD(DT_NODELABEL(bq25120a), load_switch)
|
Build output available: |
|
Build output available: |
A draft PR for running the pipeline.
Please don't merge.