Skip to content

Conversation

@DPJProgramming
Copy link
Contributor

Description

Added BG8 test case in readingsBarGroupQuantity.js
Added file expected_bar_group_ri_15-20_mu_kWh_gu_MJ_st_-inf_et_inf_bd_1.csv

David Jarvis - @DPJProgramming
Dale - @dalejk88
Eric - @eboyd3443
Garrett Ballreich - @Gballreich

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

File added: expected_bar_group_ri_15-20_mu_kWh_gu_MJ_st_-inf_et_inf_bd_1.csv
@DPJProgramming
Copy link
Contributor Author

BG8 is ready for review

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @DPJProgramming, @dalejk88, @EBoyd3443 & @Gballreich for their first contribution to OED. Review and testing found it works as desired. Congratulations having this accepted.

@huss huss merged commit e24cdcd into OpenEnergyDashboard:development Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants