-
Notifications
You must be signed in to change notification settings - Fork 438
time varying conversion/ frontend #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
minhtriet359
wants to merge
298
commits into
OpenEnergyDashboard:timeVary
Choose a base branch
from
oed-csumb-su25:evan-carey/days-edit
base: timeVary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
298 commits
Select commit
Hold shift + click to select a range
7a6e8ed
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ 6eccbe3
created UI for day overview page and create day modal
minhtriet359 f13fa05
Merge remote-tracking branch 'backend/taliaBranch' into triet_overvie…
minhtriet359 745c094
fixed db fail build error
tfrendl 70f0da5
hooked up day to backend
minhtriet359 24abf08
added check to make sure days cannot have the same name
minhtriet359 da3e438
hooked conversion create modal - need to connect pattern
minhtriet359 7fba152
Merge remote-tracking branch 'origin/evan-carey/weeks-api' into Triet…
minhtriet359 69c2ebb
fix merge errors
minhtriet359 7bb4599
hooked up create conversion to backend
minhtriet359 f09b4c7
corrected insertData to insert into conversions and conversion segments
tfrendl d3f5dab
made order of methods in models consistent
tfrendl e9bdc07
revert changes to git.ignore and docker-compose.yml
minhtriet359 24020a5
middleware for admin authentication
tfrendl 2db8158
consistent success messages from routes
tfrendl cdd8fc4
routes check id is an integer, updated validConversionSegments in con…
tfrendl 91d3d23
Merge timeVaryingConversion into edit-conversions: resolved translati…
PRINCESANCHEZ d83c9ad
start->startTime
tfrendl f9a9f93
day_name -> name
tfrendl cdec8e0
Merge Talia’s taliaBranch into edit-conversions after resolving confl…
PRINCESANCHEZ f2ec3f8
order conversion segments by start time
tfrendl 850c96d
removed start and end time
tfrendl e47ed45
multi-value requests sent as post route instead of get
tfrendl c2e769e
indentation spaces -> tabs
tfrendl 89dec2f
removed date-time type requirement, as it wouldn't accept -infinity/i…
tfrendl 83d8d78
delete also requires end time
tfrendl ee67bf6
start time and end time cannot be null
tfrendl 4182304
delete conversion segment requires end time
tfrendl 7f8bc9b
edit requires name
tfrendl 72f8fde
require not null values for edit route, delete route only takes id
tfrendl 6424e32
edit requires all not null values
tfrendl 92bd352
undo formatting changes to docker-compose
evan-carey 109fd51
undo formatting change to docker-compose
evan-carey 026b882
Address code review comments for Weeks feature
evan-carey 22ee2c1
Revert docker-compose.yml to match development branch
evan-carey c089e38
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ a66561b
Add files via upload
Gomez-V 86ed698
verifyConversion check -> todo
tfrendl d391acb
conversion segment requires endTime for delete and for retrieving a s…
tfrendl ee8a919
handle timestamp/text datatype conversions between sql and javascript
tfrendl 89cb736
updated insert day segment that updates overlapping segments - commen…
tfrendl 3f55c76
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ c3a6cdb
fix(weeks): WeeksDetailComponent does not need a loading spinner
evan-carey 16e9ee7
Edit Pattern Components
Gomez-V 336f928
Add conversionSegments Redux API and implement split segment logic
PRINCESANCHEZ d441a89
Merge branch 'evan-carey/weeks-api' into evan-carey/days-edit
evan-carey 00fa5aa
Merge remote-tracking branch 'origin/edit-conversions' into evan-care…
evan-carey 9986a57
added comment regarding cascade in day_segments
tfrendl 0e79628
[wip] Edit Day feature
evan-carey edeecf7
conn.oneOrNone -> conn.one
tfrendl 972b2c4
throw error -> try/catch, log.error
tfrendl 669c841
verify time coverage conversion segments and re-cast start_time in db…
tfrendl eb63051
rolled back time span check in route to move to model
tfrendl 4b4712f
move ConversionSegmentData interface to separate file for modularity
PRINCESANCHEZ c595d12
feat(days): Edit Day feature
evan-carey cc74833
chore: dead code and comments cleanup
evan-carey c9d87fc
Merge pull request #1 from oed-csumb-su25/evan-carey/weeks-api
evan-carey cab42e6
verify full time coverage when editing day and conversion segments
tfrendl 92dfe3a
cleanup modal state, add multi-field error handling, update API endpo…
PRINCESANCHEZ a0c56ed
passed all postman api endpoint testing
tfrendl 74329bc
updated comments
tfrendl ca8f960
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
evan-carey 3ae7ab7
Add delete logic + i18n for field errors
PRINCESANCHEZ e5c3dc3
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ 4ff9c5a
import failure
tfrendl c1a59c2
corrected [] to {} in sql files
tfrendl 7d0b7fc
added param descriptions and updated error message handling in routes
tfrendl 3adb6d2
safer way for validating id in routes, format for response
tfrendl 214ebcf
return validation error message for all route functions
tfrendl 77f5d34
removed try/catch around update segment .sql calls
tfrendl 61ab22a
added checks for segment tables that start < end
tfrendl 8122f99
implemented moment for conversion segment
tfrendl b1030aa
updates for moment() in conversion segment
tfrendl 51da7ae
cleaned up unecessary try/catch
tfrendl 9180c06
feat: implement internationalization for day editing and segment spli…
Gomez-V e83f7e1
Merge branch 'backend/taliaBranch' into Triet/backend_integration
minhtriet359 fbbd313
Merge branch 'timeVaryingConversion' into Triet/backend_integration
minhtriet359 38f58cf
fixed handling infinity values
tfrendl fcdee3d
unique check on day segments table
tfrendl 8366376
updated /add to /addComponentName
tfrendl 92ddc02
updated /add to /addComponentName
tfrendl c1bebba
changed dayName to name
minhtriet359 9059525
Merge branch 'backend/taliaBranch' into Triet/backend_integration
minhtriet359 065abeb
feat(days): ability to edit day segment hours
evan-carey 260c1dc
Merge branch 'evan-carey/days-edit' of https://github.com/oed-csumb-s…
evan-carey fb414b8
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
evan-carey 5e667fb
update endpoints to match server; fix bad file path on server
evan-carey 692be81
changed all daily patterns to days
minhtriet359 0b2329c
fixed space indetations
minhtriet359 d7f33a6
Clean up EditConversionModal: fix delete edge cases, error handling, …
PRINCESANCHEZ 357f291
removed file directory
tfrendl c927ace
added French and Spanish translations for daily.patterns
Gomez-V 2a190d4
made necessary naming and logic adjustments per reivew
minhtriet359 1e0b033
Fix datetime handling, split logic, and styling in Edit Conversion modal
PRINCESANCHEZ b5ac72d
Merge branch 'evan-carey/days-edit' into Triet/backend_integration
minhtriet359 ef3ada3
converted daily.patterns to days
minhtriet359 a65656c
create conversion only show warning when no pattern
minhtriet359 60ac3b3
Merge remote-tracking branch 'origin/Triet/backend_integration' into …
PRINCESANCHEZ 8460566
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ 3f4b2a4
Refactor EditConversionModal: separate segment save, centralize <hr> …
PRINCESANCHEZ ae66225
Refactor conversionSegmentsApi: clean up tags, remove transformRespon…
PRINCESANCHEZ 8f4138e
fixed valid tags for page reload when edit day, added notification fo…
minhtriet359 3130482
fixed route mismatch for conversionSegment
minhtriet359 c672193
Merge remote-tracking branch 'origin/Triet/backend_integration' into …
PRINCESANCHEZ 1c755ea
Add leading slash to sourceDestination URL and license header to conv…
PRINCESANCHEZ 0e12b72
fixed splitting conversion not working
minhtriet359 f2c001c
Fix segment save validation and add -99 handling for No Pattern option
PRINCESANCHEZ 5fb4d76
removed extra spaces and converted indentations to tab
tfrendl 628783d
refactor: remove unnecessary sorting from Edit and Delete segment han…
PRINCESANCHEZ 94d9442
added migrations and updated week_patterns week_name -> name
tfrendl 76ec31b
Refactor: Add interface for editing conversion segments with original…
PRINCESANCHEZ b9c6cf3
add order for creating new and altered tables
tfrendl 90dd52d
weekName -> name
tfrendl 8e4e37b
weekName -> name
tfrendl 67d6b5b
fix(days): missing translation; broken paging in segments table; cac…
evan-carey dd34818
fix: lint errors
evan-carey d147c61
delete after and earlier for segments
tfrendl 6bd4066
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
evan-carey abf05d7
refactor(weeks): change Week property `weekName` to `name` to match b…
evan-carey aa38136
after -> later
tfrendl b325d6c
removed commented out code from conversions table
tfrendl 13d6c8d
migrations: insert conversions into conversion_segments
tfrendl 13d2c82
updated error
tfrendl ab5fcb0
Fix error handling for split and edit segment fields
PRINCESANCHEZ dbcc9a2
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ 2999591
do not allow deleteEarlier for 0/-inf, do not allow deleteLater for 2…
tfrendl 7a5b9fe
Implement split and delete functionality for time-varying conversion …
PRINCESANCHEZ a03c8a5
delete later and delete earlier passed API endpoint testing
tfrendl 6ed174f
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
PRINCESANCHEZ ca8bf34
replaced create_reading_views.sql with version from OpenEnergyDashboa…
tfrendl 2c8650f
replaced create_cik_table.sql with version from OpenEnergyDashboard/d…
tfrendl cc71165
added missing header
tfrendl 0ce95f0
reverted update from previous team documentation
tfrendl 1ed9ff7
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
evan-carey 2e54383
fix(days): SQL script params don't match model for deleting and updat…
evan-carey 22c2fca
refactor(days): update front-end day segments API to match backend
evan-carey 8dd1336
Merge remote-tracking branch 'origin/edit-conversions' into evan-care…
evan-carey 1ad4b91
feat(days): resolve code review comments
evan-carey 4151fbc
Merge pull request #2 from oed-csumb-su25/evan-carey/days-code-review
evan-carey 025aa96
remove current frontend team's changes
tfrendl 320340f
removed two spacing changes
tfrendl f122842
revert docker-compose changes
minhtriet359 64fc4b5
resolved minor spacing and styling change requests
tfrendl 7ecb474
day segment delete earlier and delete later include dayId
tfrendl a147fa8
day segment delete requires dayId instead of id
tfrendl 06da585
removed get all functionality for conversion segments
tfrendl 25da8b9
removed get all functionality for day segments
tfrendl 4d01ca7
conversionSegment transactions route -> model
tfrendl c4295e8
day segment transaction route -> model
tfrendl e1e635e
days transaction route -> model
tfrendl dd339a7
removed unecessary transaction
tfrendl f50c122
day segment update checks to see if it was start or end that changed
tfrendl d3f476c
moved reused function to a new util file
tfrendl 8553592
removed unecessary ::TIMESTAMP casting in SQL files
tfrendl f472b9f
added comments about casting, removed unecessary casting
tfrendl 08f99b0
removed extra try/catch
tfrendl 21a75c0
removed unecessary SQL file
tfrendl a379f72
Merge branch 'development' into development
minhtriet359 cb4f6e1
Merge pull request #4 from oed-csumb-su25/development
minhtriet359 b12aed7
Merge branch 'development' into evan-carey/days-edit
minhtriet359 a29dee8
splitEarlier for conversion segments
tfrendl 36381ca
splitEarlier for conversion segments
tfrendl 1adb9ee
splitLater for conversion segments
tfrendl 0d912ce
splitEarlier for day segments
tfrendl ccc8477
splitLater for day segments
tfrendl 50e6250
insert model for day segment requires spanning from 0-24
tfrendl 7045cbb
insert model for conversion segments only allowed -infinity to infinity
tfrendl 7a4030d
conversion segment split earlier passed testing
tfrendl 1743785
conversion segment split later passed testing
tfrendl 72c3861
updated spacing and comments
tfrendl 4a31ee8
cannot insert -infinity to infinity conversion segment if segs alread…
tfrendl f0a2f6f
splitEarlier day segment passed tests
tfrendl a75c85f
split later day segment passed tests
tfrendl 7ec2df5
number -> integer where relevant
tfrendl 0858d73
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
evan-carey e9090ef
Fix typo in comment from segmentsApi to conversionSegmentsApi
PRINCESANCHEZ 265f38f
fix(translations): remove non-translated symbols and restore colon wi…
PRINCESANCHEZ 0293082
chore: revert changes to .gitignore and docker-compose
evan-carey 484df8f
Merge pull request #5 from oed-csumb-su25:evan-carey/code-review
evan-carey 96593d9
fix(weeks): address code review comments for CreateWeekModal
evan-carey 8bc0661
fix(weeks): address code review comments for EditWeekModalComponent
evan-carey 615b09b
fix(days): address some code review comments for DeleteDaySegment
evan-carey 29dacf9
Refactor: remove null from weekPatternsId, add blank line, localize P…
PRINCESANCHEZ 70953de
fix(days): address code review comments for EditDayModal
evan-carey dc39352
fix(conversions): a11y - add aria-label to truncated segment note cell
evan-carey fc4b4d9
refactor: remove ModalHeader toggle from Week and Day modals
evan-carey 7ac9e14
style(days): center note modal on EditDayModal component
evan-carey d83956d
fix(days): change EditDaySegment validation according to code review
evan-carey ae8a7d2
feat(days): move day segment split logic to back-end
evan-carey f7a4991
refactor(days): use Day types for days API
evan-carey 6d80b33
Merge pull request #6 from oed-csumb-su25/evan-carey/code-review
evan-carey 5257b57
fix(header): route should be lowercase
evan-carey 54ad9cf
fix(days): don't need to check if name exists when sorting days
evan-carey 44c1ff5
fix(days): error messages shouldn't say "Please try again"
evan-carey b9fcd65
Merge pull request #7 from oed-csumb-su25/evan-carey/code-review
evan-carey 174ee41
refactor: reuse "intercept" and "edit" keys from translation file
evan-carey 69685dd
refactor: reuse "slope" translation key for conversion and day views
evan-carey 870f074
fix(days): remove commented out code
evan-carey b9b3f96
Merge pull request #8 from oed-csumb-su25/evan-carey/code-review
evan-carey 445ebdc
Refactor unnecessary styling for edit conversion modal
PRINCESANCHEZ ea763de
refactor: use the `useTranslate` hook in components instead of the `t…
evan-carey 9629d4a
fix(redux/api): remove unused tag type
evan-carey 7abdd8a
Merge pull request #9 from oed-csumb-su25/evan-carey/code-review
evan-carey b96ee3a
Remove refetchSegments call and simplify error notification arguments
PRINCESANCHEZ 6df9272
Implement splitEarlier and splitLater routes, and handle -99 weekPatt…
PRINCESANCHEZ 4eb5f9c
Add success notification and unwrap() for split/delete segment actions
PRINCESANCHEZ b19c9b2
Replaced intl.formatMessage with translate() for static strings witho…
PRINCESANCHEZ 7d6afb5
Fix neutral segment warning flow and backend constraint error on dele…
PRINCESANCHEZ 2cc09b7
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ 005cfcc
Make delete buttons hidden instead of disabled
PRINCESANCHEZ 75b4c62
addressed required changes for conversions.ts and CreateConversionModal
minhtriet359 5914dfc
Merge branch 'evan-carey/days-edit' of https://github.com/oed-csumb-s…
minhtriet359 9d67c8b
Enable editing slope, intercept, pattern, and note when splitting con…
PRINCESANCHEZ 1360183
Enable editing slope, intercept, pattern, and note when splitting con…
PRINCESANCHEZ 87b3e5c
made required changes for addConversion and addDay modals
minhtriet359 f363755
Merge branch 'evan-carey/days-edit' of https://github.com/oed-csumb-s…
minhtriet359 2288a2c
Merge remote-tracking branch 'origin/evan-carey/days-edit' into edit-…
PRINCESANCHEZ e0dd651
Refactor EditConversionModalComponent with child components; update s…
PRINCESANCHEZ 62a1c51
Add comment for SplitConversionSegmentPayload and fix minor indentation
PRINCESANCHEZ 613942c
remove hardcoded string and remove minimum constraint to support -99 …
PRINCESANCHEZ 003bce9
Centralize css styling and update translation strings
PRINCESANCHEZ 81eed88
feat(days): show success message on splitting day segment
evan-carey cc25461
feat(days): show success notification on deleting a day segment
evan-carey 8c6686c
fix(translations): "Segments Table" -> "Day Segments Table"
evan-carey 0a0c91c
fix(translations): "week.delete.confirm" missing Spanish translation
evan-carey 459465b
simplify handleSourceIdChange/handleDestinationIdChange and set defau…
minhtriet359 2babc47
Shorten reactstrap import and add modal divider in Days Edit
PRINCESANCHEZ 5a6d6c8
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ d1dae3a
fix: Remove unused warning modal state when closing delete segment modal
PRINCESANCHEZ 685b5e9
Add validation to prevent split times outside segment range
PRINCESANCHEZ cb80349
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ 82fe7f7
Align modal table row count with other tables (20 rows)
PRINCESANCHEZ 3c8cf92
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ 52252c6
add default row count constant for consistent pagination across table…
PRINCESANCHEZ ac109a5
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ ad1b59e
Update split flow to match day behavior
PRINCESANCHEZ 0102914
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ c8c849a
Allow editing segment start/end with neighbor auto-update and validation
PRINCESANCHEZ 612799c
refactor: improve datetime validation, clear errors on input, remove …
PRINCESANCHEZ bfaf3cd
disable save when unchanged and add success/error notifications
PRINCESANCHEZ 615b227
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ c5ecc50
remove unused exports
PRINCESANCHEZ 2da5d3f
Merge branch 'edit-conversions' into evan-carey/days-edit
PRINCESANCHEZ 576c2ae
remove edit conversion warning
huss 26e7e0a
commenting change to address PR comment
huss b8ef6b5
Add error handling with showErrorNotification for neighbor segment au…
PRINCESANCHEZ c61046b
Update split time placeholder to use complete and move to translations
PRINCESANCHEZ 692ed35
add comments to explain git add . usage for invalid props
PRINCESANCHEZ e2dd45f
Use .then/.catch for neighbor segment adjustments
PRINCESANCHEZ 94b223b
update pattern dropdown to use translation string for no pattern
PRINCESANCHEZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.