-
Notifications
You must be signed in to change notification settings - Fork 438
Test Case CG20 #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Case CG20 #1549
Conversation
Added meterDatakWOther
Co-authored-by: Gina <[email protected]> Co-authored-by: Raquel <[email protected]>
Chocopepero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to OED. I see there are several different authors for the commits. Can you please include everyone's Github handle to the pull request (their @username)? Please also make sure everyone also signs the CLA. Thank you.
|
|
||
| // Add CG19 here | ||
|
|
||
| // Add CG20 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this comment indicating where to add the testcase.
The two empty lines below it should also be removed.
Removed comment placeholder for CG20 in test file.
|
Thank you for making that change. All contributors have signed the CLA. |
huss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @RaquelZuelke, @fluffylenny & @tazmeenahhmed for your first contribution to OED. Everything looks good and the review by @Chocopepero is taken as approving. Congratulations on an accepted contribution.
Description
Added test case CG20 to readingsCompareGroupFlow.js. Ran tests with 'npm run test'; all the tests passed.
Partially Fixes #962
Contributors: Raquel (@RaquelZuelke), Gina (@fluffylenny), Tazmeen (@tazmeenahhmed )
Type of change
Checklist
Limitations