Skip to content

Conversation

@tazmeenahhmed
Copy link
Contributor

@tazmeenahhmed tazmeenahhmed commented Oct 29, 2025

Description

Added test case CG20 to readingsCompareGroupFlow.js. Ran tests with 'npm run test'; all the tests passed.

Partially Fixes #962

Contributors: Raquel (@RaquelZuelke), Gina (@fluffylenny), Tazmeen (@tazmeenahhmed )

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Copy link
Contributor

@Chocopepero Chocopepero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to OED. I see there are several different authors for the commits. Can you please include everyone's Github handle to the pull request (their @username)? Please also make sure everyone also signs the CLA. Thank you.


// Add CG19 here

// Add CG20 here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this comment indicating where to add the testcase.

The two empty lines below it should also be removed.

Removed comment placeholder for CG20 in test file.
@Chocopepero
Copy link
Contributor

Thank you for making that change. All contributors have signed the CLA.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @RaquelZuelke, @fluffylenny & @tazmeenahhmed for your first contribution to OED. Everything looks good and the review by @Chocopepero is taken as approving. Congratulations on an accepted contribution.

@huss huss merged commit f67bde2 into OpenEnergyDashboard:development Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testing readings

4 participants