Add LR14 range test for raw meters (C → F conversion) and expected output #1557
+162
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add clear note that this is a fork of OpenEnergyDashboard/OED - Explain CodeDay MicroInternship context - Link to QUICK_START.md for students - Clarify educational purpose of repository
Student-Facing Documentation: - QUICK_START.md: 2-hour setup guide with kickoff agenda - WORKFLOW_SUMMARY.md: TL;DR of workflow decisions - FORK_WORKFLOW.md: Complete Git/fork/branch explanation - DOCUMENTATION_INDEX.md: Navigation guide for all docs Key Decisions Documented: - Students work on branches (NOT individual forks) - Feature Branching workflow (NOT GitFlow) - Kanban project board (NOT feature release) - Shared sandbox approach for learning
Project Management: - PROJECT_MANAGEMENT.md: Daily/weekly workflows, communication protocols - TEAM_TIMELINE.md: Gantt chart template for milestone tracking - TEAM_PROFILES.md: Team member profiles and mentoring strategies Features: - Clear daily standup templates - Weekly check-in procedures - Test case assignment tracking - Individual learning styles documented
GitHub Templates: - Issue template for standardized test case creation - GitHub Actions workflow for automation Automation Features: - Auto-assign issues based on labels - Update project board status automatically - Post notifications to Discord webhook - Track test implementation progress Note: Requires DISCORD_WEBHOOK secret configuration
Communication & Tools: - DISCORD_SETUP.md: Discord server structure and bot configuration - TOOL_COMPARISON.md: GitHub Projects vs ClickUp analysis - CLICKUP_GUIDE.md: Optional ClickUp integration guide Mentor Resources: - TEAM_ASSESSMENT.md: 31-question skill assessment survey - MENTOR_CHEATSHEET.md: Quick answers to common student questions Purpose: - Help mentor set up communication infrastructure - Provide decision framework for tool selection - Quick reference for common Git/workflow issues
- Friendly onboarding message for students - Clear action items and first steps - Links to all key documentation - Timeline expectations - Getting help instructions
Co-authored-by: Ngoc Pham (Vy) <[email protected]> Co-authored-by: Wei Li <[email protected]> Co-authored-by: Alngdi Mohsen <[email protected]>
Merge upstream development with test/LR14 branch
Chocopepero
suggested changes
Nov 29, 2025
Contributor
Chocopepero
left a comment
Chocopepero
left a comment
There was a problem hiding this comment.
Thank you for the contribution to OED, all contributors have signed the CLA. I've made a couple of comments regarding some minor changes. The tests work as expected.
Chocopepero
approved these changes
Dec 1, 2025
Contributor
Chocopepero
left a comment
Chocopepero
left a comment
There was a problem hiding this comment.
Changes look good. Tests work as expected
huss
approved these changes
Dec 1, 2025
Member
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
Thanks to @vyvy5555, @Livia-945, @Adam-Alhakam & @stockingstocker for their first contribution to OED. Everything looks good and the review by @Chocopepero is taken as accepting. Congratulations on an accepted contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a test case in the file readingsLineMeterRangeRaw.js that tests if the data returned from the API is as expected for min/max (range) values for line readings from raw meters. It implements test case LR14 to verify that the API correctly returns min/max values when converting from Celsius to Fahrenheit and imports the expected readings file for the test from OED DesignDocs as well.
Contributors:
Partially Addresses #[962]
Type of change
Checklist
Limitations
The test file still needs implementation of LR15, LR16, LR17, LR22.