Skip to content

Conversation

@lehned
Copy link

@lehned lehned commented Jul 20, 2022

There are two commits:
1st: FoE has incorrect BUSY handling without resending a packet and therefore aborting due timeout on wait of a never sended packet.

2nd: cleanup win32 examples and adding CMakeFiles, additional enabling win32 them by default for tests

@nakarlsson
Copy link
Contributor

Does this PR supersede the PRs provided by @blocksebastian?
#623
#624

@nakarlsson
Copy link
Contributor

@lehned , ping

@lehned
Copy link
Author

lehned commented Nov 1, 2022

Sorry for the late answer. It supersede #624 not #623, which has additional changes in other files .
As i remember there were an issue with sendpacket (FoE Packet number) counter on BUSY state, which i addressed, also.

@blocksebastian
Copy link

Does this PR supersede the PRs provided by @blocksebastian? #623 #624

Yes, that was my old account (which is taken by project paperwork).

@blocksebastian
Copy link

Sorry for the late answer. It supersede #624 not #623, which has additional changes in other files . As i remember there were an issue with sendpacket (FoE Packet number) counter on BUSY state, which i addressed, also.
Which issue? Can you explain?

@nakarlsson
Copy link
Contributor

@lehned and @blocksebastian , to make the review easier on this topics, can we close #624 and #56?
Continue to review #623 and #627?

@blocksebastian
Copy link

we can close the old #56. I splitted the old one into multiple as this project didn't react and hoped it will be integrated if I make the pull requests smaller and one topic a pull-request.

@lehned
Copy link
Author

lehned commented Nov 21, 2022

Sorry for the late answer. It supersede #624 not #623, which has additional changes in other files . As i remember there were an issue with sendpacket (FoE Packet number) counter on BUSY state, which i addressed, also.
Which issue? Can you explain?

The sendpacket counter will become corrupt, in case the client application verifies the packet counter.

markosankovic added a commit to synapticon/SOEM that referenced this pull request Jul 29, 2024
hstroetgen pushed a commit to synapticon/SOEM that referenced this pull request Apr 15, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants