fix: add missing parameters to printf #815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakarlsson
reviewed
Jun 10, 2024
test/linux/aliastool.c
Outdated
| { | ||
| if(eeprom_writealias(slave, alias)) | ||
| printf("Alias %4.4X written successfully to slave %d\n"); | ||
| printf("Alias %4.4X written successfully to slave %d\n", (unsigned)alias, slave); |
Contributor
There was a problem hiding this comment.
Is the explicit cast necessary? There are other similar calls for fprintf not having it.
Author
There was a problem hiding this comment.
No, the explicit cast is not necessary.
I checked the documentation, and since the argument undergoes integer promotion, it is not needed.
I removed the explicit cast and force pushed the change.
Signed-off-by: Henrik Cohrs <[email protected]>
|
|
Author
|
I signed the CLA, but something does not seem to be working. In GitHub, it still says, that I need to sign it. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the missing parameters to the printf() in void eepromtool(). Alias is cast to unsigned, as %x expects an unsigned int.