Skip to content

Conversation

@thopiekar
Copy link

Just added a new variable "BUILD_STATIC" to build libsoem statically or not.
By default it will now build libsoem as shared library.

Just added a new variable "BUILD_STATIC" to build libsoem statically or not.
By default it will now build libsoem as shared library.
@hefloryd
Copy link
Contributor

Our main use-case is to cross-compile SOEM for other architectures, most of which don't have shared libraries. An easy way to enable shared libraries would be useful but it should default to static libraries.

Also, did you try building this on windows? It seems to fail there.

@thopiekar
Copy link
Author

Hey @hefloryd ,

first of all thank you for your feedback. I personally work in a pure Linux environment and already packaged here locally SOEM as an debian package. For me it makes sense to build it as an shared library and so far it works perfectly.
Never tested my work on other OSs, also if you like that SOEM shall be build statically by default I can change my PR for this.

I'm open for any discussion 😉

@jumo-sballing
Copy link

Building SOEM as shared lib would be a great feature. I have to edit the makefile manually every time.
Unfortunatelly I also cannot test the build on windows.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants