merge 4.0.5 updates and dev changes into dev-cbind
#2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was using log maps in the steady-state solver for differencing, but the perturbation function assumed they were angles when it adjusted them later
- set `NumPulseGate` and `NumBeam` consistently so we can cleanup some of the IF statement in the code - don't allow pulsed lidars to have 0 gates - remove unused lidar states - updated computation of `MsrPositionsY` and `MsrPositionsZ` for pulsed lidar. Previous calculations didn't make any sense to me
- move all lidar parameter initialization into lidar_init - remove unused lidar_initInput values and move the one that is used into InflowWind initInput - remove unused variables - check that lidar arrays are allocated before initializing them (before call to SrvD_Init and before reading from IfW file) - move logic to check number of beams allowed into lidar module and only make sure the value is at least 1 before allocating so beam focal distances can be read/parsed with valid arrays sizes - make ConsiderHubMotion an integer again since I don't want to change the input files
- remove unnecessary lidar allocatable arrays in SrvoDyn InitInp type - remove unused URefLid from ServoDyn InitInp; the value that is passed to the controller was never initialized and doesn't make sense for a controller to use anyway. - allocate lidar arrays for controller based on number of beams and pulse gates instead of type of lidar - initialize error status in BladedInterface_End routine
20.04 was deprecated last week on GH
Update GH conda-deploy action to use Ubuntu 24.04
Cleanup LIDAR code
bug fix: Adjust steady-state solver small angle assumptions
The C++ function declaration had an extra argument InflowType, that is not present in the Fortran function definition.
was using log maps in the steady-state solver for differencing, but the perturbation function assumed they were angles when it adjusted them later
MD: Backport of PR #2658
Fix FAST_ExtInfw_Restart API
backport of #2760: bug-fix: Adjust steady-state solver small angle assumptions
Backport of GitHub Action to build windows executables on release
When running from Simulink, Matlab would end (instead of the DLL). This PR fixes the problem.
Avoid ending program when called as a shared library
[BugFix] WrVTK with VTK_fps fails
updated outlist reading in openfast_io
UA summary file names had spaces when generated with OLAF simulations. The wing/blade number was 11 characters, so most files had 10 spaces in the middle of the file name: <RootName>.W<11 character number with spaces>.UA.sum
Bug fix: remove spaces in OLAF's UA summary file name
UA summary file names had spaces when generated with OLAF simulations. The wing/blade number was 11 characters, so most files had 10 spaces in the middle of the file name: <RootName>.W<11 character number with spaces>.UA.sum
Backport #2848 (remove extra spaces from OLAF summary file name)
Fix Typo in "interpolation" in Ice Crushing Modules
Release 4.0.5
merge 4.0.5 updates into `dev`
(added __pycache__ to .gitignore)
RyanDavies19
approved these changes
Jun 16, 2025
Contributor
RyanDavies19
left a comment
RyanDavies19
left a comment
There was a problem hiding this comment.
MD changes look good to me
deslaughter
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
This PR merges in v4.0.4, v4.0.5, and
devchanges that are not indev-cbindyet.Related issue, if one exists
Follow on to #2859
PR's from
devthat weren't merged over before now:Additional supporting information
All the changes here have been reviewed elsewhere. Only a couple of files need review as there were merge conflicts during this update:
.github/workflows/automated-dev-tests.ymlmodules/aerodyn/src/AeroDyn_Inflow_C_Binding.f90modules/moordyn/src/MoorDyn_Misc.f90- manually applied Fix typos #2816 to correct conflicts hereTest results, if applicable
r-test/dev-cbindbranch during merge