Merge dev-cbind to dev (c-bindings updates) #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AddedMass that returns the instantaneous added-mass matrix for all input nodes and the reminder of the total hydro loads without added-mass contributions The Python library is also updated to support the new C-binding subroutine
…ts, improve some names, add usage instructions etc.
…rface Refactor the Aerodyn/Inflowwind Python interface to the C-bindings interface
…ng FF from unnecessary deallocation call (already was deallocated)
Could also be a protocol
Fix Intel compiler error for comment after string literal
MoorDyn wave directional spreading and custom current profile if no SeaState current
MD cbind: correction to description of mesh point mapping
(added __pycache__ to .gitignore)
merge 4.0.5 updates and `dev` changes into `dev-cbind`
andrew-platt
added
Module: AeroDyn
Module: HydroDyn
Module: MoorDyn
Module: InflowWind
Module: NWTC Lib
Module: SeaState
Collaborator
Author
|
deslaughter
approved these changes
Jun 16, 2025
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
I'm not a huge fan of hard coded paths on Raf's machine in the Python libraries, but I'm not sure that it matters
Collaborator
Author
|
I'm not a fan of hard coded paths either. I think those files are leftover from development and should be removed (see issue #2864) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Several improvements to the c-bindings interfaces were made on the
dev-cbindbranch, as well as the creation of a newpyOpenFASTPython module for regression testing.Related issue, if one exists
PR's that are unique to the
dev-cbindbranch (already reviewed):AeroDyn
HydroDyn
MoorDyn
SeaState
Testing
Impacted areas of the software
C-bindings interfaces:
NWTC_C_Binding.f90- new NWTC library file for use in all the c-bindings libraries (cleans up interface)Testing:
Testing now requires importing of the
pyOpenFASTlibrary. This library collects many of the old Python scripts for module level c-bindings interface tests into a single location. But to use this, the end user must do apip install -e <openfast>/python/pyOpenFAST/.prior to running tests.Additional supporting information
All code in the PR was reviewed in the above PR's.
Test results, if applicable
Python c-bindings based module tests for AD, HD, IfW, and MD were updated to use the new
pyOpenFASTpython interfacing library.